X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/ef410fd2370c90c4390d3f50f1e104f18b8d20c0..b5a05dbc33a1a24a6a20701d2756a2d4f4a77995:/doc/bugs/linkmap_displays_underscore_escapes.mdwn diff --git a/doc/bugs/linkmap_displays_underscore_escapes.mdwn b/doc/bugs/linkmap_displays_underscore_escapes.mdwn index 3d9fb80db..16080358b 100644 --- a/doc/bugs/linkmap_displays_underscore_escapes.mdwn +++ b/doc/bugs/linkmap_displays_underscore_escapes.mdwn @@ -1,3 +1,5 @@ +[[!template id=gitbranch branch=chrysn/linkmapenhancement author="[[chrysn]]"]] + [[ikiwiki/directive/linkmap]]s display the file name instead of the pagetitle, showing unsightly underscore escapes and underscores instead of blanks to users. the attached [[!taglink patch]] fixes this; from its commit message: @@ -13,4 +15,23 @@ the attached [[!taglink patch]] fixes this; from its commit message: because it can represent the '\"' dyad properly, and because it doesn't need special-casing of newlines). -see [[0001-display-the-pagetitle-in-linkmaps.patch]] for the patch. +the output will look much better (at least in my wikis) with the "[[bugs/pagetitle function does not respect meta titles]]" issue fixed. + +> [[Looks good to me|users/smcv/ready]]. +> +> I don't think it's correct for `pagetitle()` to output `\[[!meta title]]` +> though, as discussed on the linked bug: it appears in an assortment of +> contexts where the full formal title of the page seems inappropriate. +> If you want linkmap to use `\[[!meta title]]`, I think it would be +> better to give it a `show` parameter, like `\[[!map]]` has? +> --[[smcv]] + +>> sounds good; i'll have a look at it the next time i touch the linkmap +>> plugin. the patch at hand would be a starting point for that. --[[chrysn]] + +the patch is stored in [[the patch.pl]] as created by git-format-patch, and can +be pulled from the abovementioned branch. + +> update 2014-06-29: branch still merges cleanly and works. --[[chrysn]] + +>> [[merged|done]] --[[smcv]]