X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/eb9353384294964372349deba7a2b016e793b290..4e77f22f48222ec1493f0b2052fdba09379206f0:/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn

diff --git a/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn b/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn
index e3a57e184..fbdccc5b2 100644
--- a/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn
+++ b/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn
@@ -1,4 +1,4 @@
-[[!template  id=gitbranch branch=feature/15355-po-plugin-disable-languages author="[[hefee]]"]]
+[[!template  id=gitbranch branch=feature/15355-po-plugin-disable-languages author="[[intrigeri]]"]]
 
 `po_disabled_languages` is used to disable languages on the website. It
 can be used to prepare new translations, while it will hide those from
@@ -7,3 +7,31 @@ normally, however, HTML creation will be disabled and no reference to
 these translations will be visible on the website.
 
 See also downstream bug report in tails: <https://labs.riseup.net/code/issues/15355>
+
+> From the downstream bug report it appears this branch is not yet
+> considered ready (as of February 2019), so I haven't attempted to
+> review it.
+>
+> As with everything else in the `po` plugin: I would really want to see
+> some regression test coverage before merging this, because as far as I'm
+> aware none of the ikiwiki maintainers use the `po` plugin, so we are
+> not able to detect regressions other than via the automated tests. That
+> isn't a good situation to be in for a plugin that uses `IkiWiki::inject`
+> to monkey-patch ikiwiki internals. If this plugin is important to you,
+> more test coverage would be very much appreciated.
+> --[[smcv]]
+
+>> I've put this branch into a shape that I now dare submitting:
+>> https://salsa.debian.org/tails-team/ikiwiki/tree/feature/15355-po-plugin-disable-languages.
+>> It adds a little bit test coverage in the form of integration tests
+>> for the proposed feature, that incidentally exercise the rest of the
+>> basic functionality of the PO plugin.
+>> Credits go to hefee for the initial work; I merely did a lot of polishing.
+>> Happy to squash all this into a single commit if you prefer.
+>> --[[intrigeri]]
+
+>>> Please let me know if the added test coverage is sufficient to unblock
+>>> the merge of this branch. Thanks in advance!
+>>> --[[intrigeri]]
+
+[[!tag patch]]