X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/e5d9d3cc52598c68fc91903a5ca5fd43c7d1cf21..89fa4c9b4dcee1ce34aa95d6981f73071f6450cf:/doc/rcs/cvs/discussion.mdwn?ds=sidebyside diff --git a/doc/rcs/cvs/discussion.mdwn b/doc/rcs/cvs/discussion.mdwn index 645b2388b..57b0d044b 100644 --- a/doc/rcs/cvs/discussion.mdwn +++ b/doc/rcs/cvs/discussion.mdwn @@ -147,3 +147,45 @@ short and clear as possible. --[[schmonz]] > that. --[[Joey]] >> Done. --[[schmonz]]. + +---- + +I'm attempting to bring some polish to this plugin, starting with +fuller test coverage. In preparation, I've refactored the tests a +bunch (and shuffled the code a bit) in my branch. I'm worried, +however, that my misunderstanding of `git rebase` may have made my +branch harder for you to pull. + +Before I go writing a whole swack of test cases, could you merge +my latest? Through at least ad0e56cdcaaf76bc68d1b5c56e6845307b51c44a +there should be no functional change. --[[schmonz]] + +Never mind, I was able to convince myself (by cloning `origin` +afresh and merging from `schmonz/cvs`). The history is a little +gross but the before-and-after diff looks right. + +Bugs found and fixed so far: + +* Stop treating text files as binary (`-kb`) on `rcs_add()` + (ac8eab29e8394aca4c0b23a6687ec947ea1ac869) + +> Merged to current head. --[[Joey]] + +---- + +Hi! Bugfixes in `schmonz/cvs` I'd like to see merged: + +* `6753235d`: Return bounded output from `rcs_diff()` when asked, as + the API states. +* `e45175d5`: Always explicitly set CVS keyword substitution behavior. + Fixes behavior when a text file is added under a name formerly + used for a binary file. +* `b30cacdf`: If the previous working directory no longer exists after + a CVS operation, don't try to `chdir()` back to it afterward. +* `91b477c0`: Fix diffurl links (cvsweb expects unescaped '/'). + +These are all the diffs that exist on the branch, so if the changes +are acceptable you should be able to simply merge the branch. +--[[schmonz]] + +> All applied. --[[Joey]]