X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/dbf9a362976edf6e97ff826915a58c93b77784c1..e71622d233660b5ba305d68e586d7d14ff2124e6:/doc/bugs/About___37__2F_problem.mdwn diff --git a/doc/bugs/About___37__2F_problem.mdwn b/doc/bugs/About___37__2F_problem.mdwn index 15f64b883..d45325711 100644 --- a/doc/bugs/About___37__2F_problem.mdwn +++ b/doc/bugs/About___37__2F_problem.mdwn @@ -64,26 +64,21 @@ not deal with Chinese char, the below link can work --- -> Please could you try to make a minimal example or test, perhaps in the [[sandbox]] -> on this wiki or as a unit test in `t/git-cgi.t` in the ikiwiki source code, that -> demonstrates this bug and would be fixed by your patch? I tried to write a test -> for this, and I was able to make a test that uses a UTF-8 `rootpage` and fails; -> but your patch doesn't seem to fix it, so you must be seeing something different. -> I think there might be more than one bug here. +> [Request for clarification removed] > -> If you've found multiple bugs, a separate example or test for each one would be -> easiest to deal with. +> I've now been able to reproduce this bug, and confirmed that your patch +> fixes it. [[Patch now applied|done]]. > -> In your original report, you said the `rootpage` was ASCII and started with `./`: -> `./bugs`. Then you mentioned Chinese characters (any non-ASCII character like é or ¬ -> should behave the same as Chinese here) and attached a patch that alters how those -> are handled, without affecting what would happen to a `rootpage` that starts -> with `./`; so I'm confused about what the bug was, and what you are fixing? +> (For other maintainers' reference: when testing Unicode bugs that +> relate to page titles, using Unicode that is considered to be +> punctuation, like ¬ or emoji, will probably not work; page titles +> treat `[:alnum:]` and `^[:alnum:]` differently.) > -> I've added tests to `t/git-cgi.t` which demonstrate a blog form for a `rootpage` -> named `writable/blog` working correctly (which passes), and a `rootpage` named -> `writable/¬blog` not working correctly (which fails, and is marked as *TODO*). -> The patch above doesn't seem to make the second new test pass. +> In future bug reports it would be useful if you could provide a minimal +> example or test, perhaps on the [[sandbox]] on this wiki or as a unit +> test in `t/*.t` in the ikiwiki source code, that demonstrates this bug +> and would be fixed by the patch. If you've found multiple bugs, a +> separate example or test for each one would be easiest to deal with. > > You can run all the tests with: >