X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/db247437fd575a921adbf610c71276d3200442fa..ae1857b43cf55a393a507b8434f172cbdb29d5b0:/doc/todo/need_global_renamepage_hook.mdwn?ds=inline

diff --git a/doc/todo/need_global_renamepage_hook.mdwn b/doc/todo/need_global_renamepage_hook.mdwn
index 906bf1220..e3cec4a9b 100644
--- a/doc/todo/need_global_renamepage_hook.mdwn
+++ b/doc/todo/need_global_renamepage_hook.mdwn
@@ -61,7 +61,7 @@ would solve my problem. Hmmm? --[[intrigeri]]
 >>> not be broken. I will thus keep the existing `renamepage` as it
 >>> is, and call `rename` the global hook I need. --[[intrigeri]]
 
->>>> Done in my `po` branch. --[[intrigeri]]
+>>>> [[Done]] in my `po` branch. --[[intrigeri]]
 
 I think I see a problem in the rename hook. The hook is called
 before the plugin adds any subpages to the set of pages to rename.
@@ -87,6 +87,8 @@ hashes is desired, it could return the full set of hashes.
 > though, because one can't build a hash containing an array of hashes
 > as a value, without passing this array as a reference.
 > 
+>> Sure.
+> 
 > I'm not entirely sure about your first concern. Calling the hook
 > before or after the subpages addition both have their own problems.
 > 
@@ -95,3 +97,19 @@ hashes is desired, it could return the full set of hashes.
 > a given hook function can choose to act only before or after, or both?
 > 
 > --[[intrigeri]]
+>> 
+>> Have you thought about making the hook be run once *per* file that is
+>> selected to be renamed? This would even handle the case where two
+>> plugins use the hook; plugin A would see when plugin B adds a new file
+>> to be renamed. And the subpage renaming stuff could probably be moved
+>> into the rename hook too. --[[Joey]] 
+>>>
+>>> I've implemented this nice solution in my po branch, please review.
+>>> I'm slowly coming back to do the last bits needed to get my po and
+>>> meta branch merged.  --[[intrigeri]]
+
+>>>> It looks good. I made some small changes to it in my own po branch.
+>>>> Nothing significant really. If this were not tied up in the po branch,
+>>>> I've have merged it to master already. --[[Joey]] 
+
+>>>> Thanks, this is great :) --[[intrigeri]]