X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/d614c97d361972de0c41201688de414867f359c8..97819910b83aed6784e78cc28554584785d92497:/doc/todo/monochrome_theme.mdwn?ds=sidebyside diff --git a/doc/todo/monochrome_theme.mdwn b/doc/todo/monochrome_theme.mdwn index a1956e683..eaf51c080 100644 --- a/doc/todo/monochrome_theme.mdwn +++ b/doc/todo/monochrome_theme.mdwn @@ -11,3 +11,38 @@ Perhaps controversially, I think that this would be a good basis for a default t > redundant since ikiwiki's style.css gets prepended to the theme's stylesheet > at build time! Can you remove those redundant bits please? (PITA I know, > but it will make maintaining this much easier.) --[[Joey]] + +>> Sure I'll sort that out. Sorry, I didn't realise the prepending was an automatic process. I did it manually. It should be quick for me to fix. — [[Jon]] + +>>> Fixed. I rebased the branch; hopefully that won't cause your script issues. — [[Jon]] + +>>>> I've merged your branch. +>>>> +>>>> Looking more closely at the css, I do have a few questions: +>>>> +>>>> * Is the google-provided font really necessary? I consider that a sort +>>>> of web bug, I would prefer users of ikiwiki not need to worry that +>>>> their referer information is being sent to some third party. +>>>> I'd also prefer for ikiwiki sites to always be functional when +>>>> viewed offline. +>>>> * The external link markup needs the local url to be put into +>>>> local.css to work right, correct? I wonder if this is too much of a +>>>> complication to ask of users. It seems to be it could either be left +>>>> out of the theme, or perhaps ikiwiki could be made to expand +>>>> something in the css to the site's url at build time. +>>>> +>>>> --[[Joey]] + +>>>>>Thanks for merging! +>>>>> +>>>>> * the font is not necessary. I will check, it might be license-compatible +>>>>> and thus could be bundled. As things stand, if people have no 'net connection +>>>>> or the font fails to load, the theme still "works". Good point RE the referral +>>>>> situation. +>>>>> +>>>>> * The external link markup works without customizing the CSS, but if something +>>>>> generates a non-relative link within the content area of a page, it will be +>>>>> styled as an external link. By default, nothing does this in ikiwiki afaik, +>>>>> so the impact is pretty small. (except perhaps if someone specifies an absolute +>>>>> `cgiurl` path?) The additional customization is belt-and-braces. +>>>>> — [[Jon]]