X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/d5e65e582a34ae2494fee493ddcb2b959e4a4bce..7d36f1000a83176df979325e7ea5446ef1d7f501:/doc/todo/darcs.mdwn?ds=inline diff --git a/doc/todo/darcs.mdwn b/doc/todo/darcs.mdwn index e757867d2..a410f5ecf 100644 --- a/doc/todo/darcs.mdwn +++ b/doc/todo/darcs.mdwn @@ -484,4 +484,43 @@ I have addressed the recentchanges bit, you can find my hacked up darcs.pm at + +I've taken all the good stuff from the above and added the missing hooks. Some of them I haven't had a chance to test, namely `rcs_rename`, `rcs_remove`, `rcs_commit_staged`, and `rcs_diff`. Also, I'm not experienced with perl and don't know where I should have used the function `possibly_foolish_untaint`. + +Regarding the repository layout: There are two darcs repositories. One is the `srcdir`, the other we'll call `master`. + + * HTML is generated from `srcdir`. + * CGI edits happen in `srcdir`. + * The backend pulls updates from `master` into `srcdir`, i.e. darcs commits should happen to `master`. + * `master` calls ikiwiki (through a wrapper) in its apply posthook, i.e. `master/_darcs/prefs/defaults` should look like this: + + apply posthook ikiwrap + apply run-posthook + + (I'm not sure, should/could it be `ikiwrap --refresh` above?) + * The backend pushes CGI edits from `srcdir` back into `master` (triggering the apply hook). + * The working copies in `srcdir` and `master` should *not* be touched by the user, only by the CGI or darcs, respectively. + +> Review of this one: +> +> * Should use tab indentation. +> * `rcs_getctime` should not need to use a ctime cache (such a cache should +> also not be named `.ikiwiki.ctimes`). `rcs_getctime` is run exactly +> once per page, ever, and the data is cached in ikiwiki's index. +> * I doubt that ENV{DARCS} will be available, since the wrapper clobbers> the entire +> environment. I'd say remove that. +> * I don't understand what `darcs_info` is doing, but it seems to be +> parsing xml with a regexp? +> * Looks like `rcs_commit` needs a few improvements, as marked TODO +> * `rcs_remove` just calls "rm"? Does darcs record notice the file was removed +> and automatically commit the removal? (And why `system("rm")` and not +> `unlink`?) +> * Is the the darcs info in [[details]] still up-to-date re this version? +> --[[Joey]] + [[!tag patch]]