X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/d5e65e582a34ae2494fee493ddcb2b959e4a4bce..78201603a1e2219922ca34f6fe5635c2d10290ec:/doc/plugins/map/discussion.mdwn diff --git a/doc/plugins/map/discussion.mdwn b/doc/plugins/map/discussion.mdwn index c724a6492..54c921b0f 100644 --- a/doc/plugins/map/discussion.mdwn +++ b/doc/plugins/map/discussion.mdwn @@ -1,7 +1,7 @@ I'm wanting a [[map]] (with indentation levels) showing page _titles_ instead of page 'names'. As far as I can see, this is not an option with existing plugins - I can get a list of pages using [[inline]] and -appropriate [[wikitemplates]], but that has no indentation and therefore +appropriate [[templates]], but that has no indentation and therefore doesn't show structure well. The quick way is to modify the map plugin to have a 'titles' option. The @@ -18,3 +18,32 @@ We'd also very much like to have an option to display the title of the page inst There's a patch implementing this in [[!debbug 484510]]. It needs a few fixes before I merge it. Now applied. --[[Joey]] + +---- + +I noticed that when the pagespec returns no map items, the map plugin does not close off the ul and div tags. Below is a simple patch +that seems to work on the examples I tried. I am a beginner so please help me out here. Thanks. --[[harishcm]] + + --- a/map.pm + +++ b/map.pm + @@ -81,6 +81,13 @@ + my $openli=0; + my $addparent=""; + my $map = "
\n\n
\n"; + + return $map; + + } + + + foreach my $item (sort keys %mapitems) { + my @linktext = (length $mapitems{$item} ? (linktext => $mapitems{$item}) : ()); + $item=~s/^\Q$common_prefix\E\/// + +> This was also reported as [[bugs/map_fails_to_close_ul_element_for_empty_list]]; +> this patch is simpler than the one there, but has the same problem (it emits +> ``, which technically isn't valid HTML either). --[[smcv]] + +>> Thanks for the tip, I added another patch addressing the issue at +>> [[bugs/map_fails_to_close_ul_element_for_empty_list]]. --[[harishcm]]