X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/d3a7555534bdf3b83a61c92435115e91c714b4c0..5b494e1b636f4c26c14c9cf8f964bef0a70c784a:/doc/todo/Add_space_before_slash_in_parent_links.mdwn diff --git a/doc/todo/Add_space_before_slash_in_parent_links.mdwn b/doc/todo/Add_space_before_slash_in_parent_links.mdwn index c4dc6ede6..e07ad8ef9 100644 --- a/doc/todo/Add_space_before_slash_in_parent_links.mdwn +++ b/doc/todo/Add_space_before_slash_in_parent_links.mdwn @@ -1,4 +1,17 @@ -This patch adds a space before the forward-slash in the the parent links. There is already a space after the slash. +This [[patch]] adds a space before the forward-slash in the the parent links. There is already a space after the slash. + +> I intentionally put the space after the slash and not before, because I +> like how it looks that way. So I don't plan to apply this patch unless a +> lot of people disagree with me or whatever. --[[Joey]] + +>> Couldn't we export what's put between the links to a variable? For instance, I might actually want to set it to ' : ' or '→'. --[[madduck]] + +>>> Yes, please. This seems to be something a lot of people want to customize. (I certainly do -- a forward slash only looks natural to Unix users) --[[sabr]] + +>> Joey, would I be right to summarize your position on this as "people who +>> want to change the text of the templates should maintain their own version +>> of the `.tmpl` files"? It's not clear to me how this todo item could be +>> closed in a way acceptable to you, except perhaps as WONTFIX. --[[smcv]] Before: @@ -11,40 +24,133 @@ After: Patch: diff --git a/templates/misc.tmpl b/templates/misc.tmpl - index 80e6d0b..184920e 100644 + index 184920e..80e6d0b 100644 --- a/templates/misc.tmpl +++ b/templates/misc.tmpl @@ -15,7 +15,7 @@
- - / - +/ + -/ + + /
diff --git a/templates/page.tmpl b/templates/page.tmpl - index 1978e93..3a1ac9e 100644 + index 3a1ac9e..1978e93 100644 --- a/templates/page.tmpl +++ b/templates/page.tmpl @@ -17,7 +17,7 @@
- - / - +/ + -/ + + / diff --git a/templates/recentchanges.tmpl b/templates/recentchanges.tmpl - index 4877395..e03482f 100644 + index e03482f..4877395 100644 --- a/templates/recentchanges.tmpl +++ b/templates/recentchanges.tmpl @@ -15,7 +15,7 @@
- - / - +/ + -/ + + /
+ +---- + +It's almost implicit in some of the discussion above but this can be achieved locally if you fork your templates directory from ikiwiki's, with an ammendment such as + +

+ → +

+ +This is what I do on my site for example. -- [[Jon]] + +> You don't actually need to fork the whole directory, "only" `page.tmpl` - +> put `templatedir => "/foo/templates"` in your setup file, copy `page.tmpl` +> to that directory, and modify it there. IkiWiki will look in `templatedir` +> first, then fall back to its default templates if any are missing from +> `templatedir`. +> +> (Admittedly, `page.tmpl` is the hardest to maintain a fork of, because it +> tends to change whenever a new plugin is added...) --[[smcv]] + +---- + +Here is a solution which doesn't require people to create their own +`page.tmpl`. The solution uses an HTML list together with CSS to draw the +separator and can therefore be controlled by users. This change also +allows people to control other aspects of how the parentlinks are +displayed. The only drawback is that lynx/w3m don't seem to deal with this +CSS feature, but I don't think it's too bad since the parentlinks will +simply show up as a list. + +> I guess I could live with w3m having a second list at the top. +> +> Does this method look identical in the default theme? What about the +> other themes? Several of them do things with parentlinks css.. --[[Joey]] + +(I see that the other patch changes templates/misc.tmpl and +templates/recentchanges.tmpl for INDEXLINK. I haven't done that but can do +so if [[Joey]] likes this approach.) + +> Those template no longer have the redundant stuff. --[[Joey]] + +--[[tbm]] + + diff --git a/doc/style.css b/doc/style.css + index 35a1331..b726365 100644 + --- a/doc/style.css + +++ b/doc/style.css + @@ -129,6 +129,23 @@ pre { + overflow: auto; + } + + +ul.parentlinks li:after { + +display: marker; + +content: "/ "; + +background: none; + +} + + + +ul.parentlinks li { + +display: inline; + +} + + + +ul.parentlinks + +{ + +padding-left: 0; + +display:inline; + +list-style-type: none; + +} + + + div.recentchanges { + border-style: solid; + border-width: 1px; + diff --git a/templates/page.tmpl b/templates/page.tmpl + index 770ac23..f54493e 100644 + --- a/templates/page.tmpl + +++ b/templates/page.tmpl + @@ -44,11 +44,15 @@ +
+
+ + + + + +
    + + -/ + +
    • +     + +
+ + + + + +