X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/c42ff91eebead9daa72434670289c43244e18bc6..f1fb8eac6a7e7fb00d111baa03786af9e7387115:/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn diff --git a/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn b/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn index 498e5ddb2..4d6506657 100644 --- a/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn +++ b/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn @@ -13,3 +13,50 @@ See the [validator output][validate] for more details. [tmpl]: http://git.ikiwiki.info/?p=ikiwiki;a=blob_plain;f=templates/recentchanges.tmpl;hb=HEAD [validate]: http://validator.w3.org/check?uri=http://ikiwiki.info/recentchanges/ + +- - - + +I'll add this here since it's related. I also noticed that the meta tags for +redirected pages need to be closed in order to be valid XHTML: + + + +I'm noticing these problems because I'm serving ikiwiki-generated +content as `application/xhtml+xml` (as opposed to `text/html`) in order +to include inline MathML. Any invalid XHTML causes Firefox to halt all +processing and throw an error. —[Jason Blevins](http://jblevins.org/) + +- - - + +Here is a simple patch for the refresh problem. I haven't figured out +what's causing the recentchanges bug yet. + + + diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm + index 8a9a538..0afe1c3 100644 + --- a/IkiWiki/Plugin/meta.pm + +++ b/IkiWiki/Plugin/meta.pm + @@ -186,7 +186,7 @@ sub preprocess (@) { #{{{ + $value=encode_entities($value); + } + my $delay=int(exists $params{delay} ? $params{delay} : 0); + - my $redir=""; + + my $redir=""; + if (! $safe) { + $redir=scrub($redir); + } + + +--[[JasonBlevins]] + +- - - + +It turns out that the invalid XHTML on the recent changes page is due to +a bug in Markdown. I was using the packaged version of markdown in +Ubuntu (Gutsy and markdown 1.0.1-6). Everything is fine +after installing the most recent version of Text::Markdown from CPAN. + +Note that the above patch for the redirect tag is still applicable and +the smiley issue remains open. --[[JasonBlevins]] + +[[tag patch]]