X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/c03d91727ffa37c7fee508242d775ac6096781e4..5560afc08543ee0b2c51d075197f6b7d6e91672a:/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn

diff --git a/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn b/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn
index b53493c0d..b641f2db2 100644
--- a/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn
+++ b/doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn
@@ -1,3 +1,5 @@
+[[!template  id=gitbranch branch=anarcat/dev/syslog_utf8 author="[[anarcat]]"]]
+
 [[this feature|todo/syslog_should_show_wiki_name]] made it so syslog doesn't work anymore if the site being logged has non-ASCII characters it in.
 
 Specifically, my wiki was named "CⒶTS", and nothing was showing up in syslog. When I changed that to "C@TS", it worked again.
@@ -12,24 +14,14 @@ My guess is this sits somewhere here:
 
 Yet I am not sure how to fix that kind of problem in Perl... --[[anarcat]]
 
-I tried to make this unit test:
-
-[[!format perl """
-#!/usr/bin/perl
-use warnings;
-use strict;
-use Test::More tests => 5;
-
-BEGIN { use_ok("IkiWiki"); }
-
-$IkiWiki::config{verbose} = 1;
-$IkiWiki::config{syslog} = 1;
-$IkiWiki::config{wikiname} = 'ascii';
-ok(debug('test'));
-$IkiWiki::config{wikiname} = 'not ⒶSCII';
-ok(debug('test'));
-"""]]
+> If I remove the "eval" above, I get:
+> 
+>     Error: Wide character in syswrite at /usr/lib/perl/5.14/Sys/Syslog.pm line 485.
+> 
+> I have improved a little the error handling in log_message() so that we see *something* when syslog fails, see the branch documented above. I can also confirm that  reverting [[todo/syslog_should_show_wiki_name]] fixes the bug. Finally, I have a unit test that reproduces the problem in git, and a working [[!taglink patch]] for the bug, again in git.
+> 
+> > One last note: I noticed that this problem also happens elsewhere in ikiwiki. For example, the [[plugins/notifyemail]] plugin will silently fail to send notifications if the pages contain unicode. The [[plugins/notifychanges]] plugin I am working on (in [[todo/option to send only the diff in notifyemail]]) seems to be working around the issue so far, but there's no telling which similar problem are out there.
 
-And I couldn't reproduce the problem. Therefore, I suspect the problem may be somewhere else - maybe in the options parsing? One thing that's for sure: when I put that funky character in the title, it breaks logging! If I remove the "eval" above, I get:
+>> [[I'd merge it|/users/smcv/yesplease]]. --[[smcv]]
 
-    Error: Wide character in syswrite at /usr/lib/perl/5.14/Sys/Syslog.pm line 485.
+>>> I've merged it, but I don't feel it fixes this bug. --[[Joey]]