X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/ba1353fed2e076bdab5145e84a3776de6981979e..bfe1961e1dc75fbf702000cde111bab208997509:/doc/todo/else_parameter_for_map_plugin.mdwn?ds=sidebyside diff --git a/doc/todo/else_parameter_for_map_plugin.mdwn b/doc/todo/else_parameter_for_map_plugin.mdwn index 4d6776229..981e50d43 100644 --- a/doc/todo/else_parameter_for_map_plugin.mdwn +++ b/doc/todo/else_parameter_for_map_plugin.mdwn @@ -1,4 +1,4 @@ -[[!tag patch]] +[[!tag patch done]] [[plugins/map]] (and I) could benefit from a bonus parameter: @@ -10,3 +10,47 @@ documentation yet, I'm waiting for feedback first, but I'll do it for sure. -- [ > Can't a [[plugins/conditional]] be for this? > --[[Joey]] + +>> Hmmm, what do you mean? Adding a syntax such as the one below? +>> Or something else? + + \[[!if test="map(" then="..." else="..."]] + +>> What would you write in the `then` clause? +>> I'm not opposed at all to rewrite my two-liner, but I don't understand. +>> --[[intrigeri]] + + \[[!if test="foo/*" then=""" + [[!map pages="foo/*"]] + """ else="no pages"]] + +--[[Joey]] + +>>> I'm not convinced: the syntax you're proposing implies to duplicate +>>> the pagespec (once in the test clause, and once in the map query), which I find +>>> not only inelegant, which I can live with, but also tiring and unpractical: +>>> my `else` suggestion +>>> finds its roots in map queries with rather long pagespecs. On the other +>>> hand, if I'm the only one using map in such a way, I can live with this +>>> heavy duplicated syntax without bloating the map plugin with features +>>> no-one but me needs. On the other other hand, the patch is a 3-liner. +>>> I'm not fixed yet, I'll think about it. --[[intrigeri]] + +>>>> Write a [[plugins/template]] which accepts a pagespec and an +>>>> "else" clause, and then you won't have to duplicate the +>>>> pagespec. --[[JoshTriplett]] + +>>>> Yeah, the patch is obviously very simple. My problem with it really is +>>>> that there would seem to be several other places in ikiwiki where +>>>> someone might want to be able to handle an "else" case where a +>>>> pagespec expands to nothing. And adding else cases for all of them +>>>> could be a bit much. --[[Joey]] + +>>>>> Agreed, and tagging as done. For the record, here is the [[plugins/template]] I use: + + \[[!if test="" + then=""" + [[!map pages=""]]""" + else=""]] + +>>>>> --[[intrigeri]]