X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/a99790e5ec38afe4d591ba27d984b367c098d5d2..c8214300ed6198d3a59cc1e3b3d74b0722c26b91:/doc/todo/web_reversion.mdwn

diff --git a/doc/todo/web_reversion.mdwn b/doc/todo/web_reversion.mdwn
index e0c6ebdf1..33fa79aad 100644
--- a/doc/todo/web_reversion.mdwn
+++ b/doc/todo/web_reversion.mdwn
@@ -67,10 +67,14 @@ Peter Gammie has done an initial implementation of the above.
 >> Please look it over and tell me what else needs fixing... -- [[peteg]]
 
 >>> I have made my own revert branch and put a few fixes in there
+>>> [[!template id=gitbranch branch=origin/revert author="[[joey]]"]]
 >>> (and fixed all the indention..). Issues I noticed but have not gotten
 >>> to: --[[Joey]] 
+>>>> Please change the git pointer above, then. I will work on your branch. -- [[peteg]]
 >>>
 >>> * `rcs_diff` already exists; why add `rcs_showpatch`?
+>>>> If `rcs_diff` is intended for human consumption, by all means we can use that. -- [[peteg]]
+
 >>> * Would it be better for `rcs_revert` to not commit, and
 >>>   `rcs_commit_staged` to then be used? This would work for git, but
 >>>   maybe other RCSs would be problimatic. It would simplifiy the
@@ -79,6 +83,9 @@ Peter Gammie has done an initial implementation of the above.
 >>>   needs it to chdir, and not the other one. It's running
 >>>   in the same git repo either way, and git doesn't need
 >>>   `git show` to run in a subdir at all..
+>>>> I was aping (preserving) what was already there. I don't understand what you say about `git show` - it must run under $srcdir, surely? And empirically the CGI process wasn't in the right place. By all means simplify that. -- [[peteg]]
+
 >>> * Probably needs to untaint the revs passed in.
 >>> * Seems backwards for `rcs_preprevert` to import and
 >>>   use `IkiWiki::Receive`.
+>>>> Indeed. This is saying that the checking code in IkiWiki::Receive is in the wrong place. I think it would be better to set up some general hooks and shuffle it into a plugin, for then other plugins that maintain special files in the repo can have a say about validity. -- [[peteg]]