X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/a7cb3090902e23e2b0f2371539ade7ec5a4ba01b..fee00fdb7a4ebb52e90f739cca33def70497620e:/doc/plugins/lockedit/discussion.mdwn?ds=sidebyside

diff --git a/doc/plugins/lockedit/discussion.mdwn b/doc/plugins/lockedit/discussion.mdwn
index b058b2b07..867fc6a51 100644
--- a/doc/plugins/lockedit/discussion.mdwn
+++ b/doc/plugins/lockedit/discussion.mdwn
@@ -1,21 +1,18 @@
-This plugin not only locks pages but ensures too a user is logged in. This seems to me redundant with signedit. I propose :
+This plugin not only locks pages but ensures too a user is logged in. This
+seems to me redundant with signedit. I propose [removing the if block that
+calls needsignin ].
 
-    sub canedit ($$) {
-    	my $page=shift;
-    	my $cgi=shift;
-    	my $session=shift;
-    
-    	my $user=$session->param("name");
-    	return undef if defined $user && IkiWiki::is_admin($user);
-    
-    	if (defined $config{locked_pages} && length $config{locked_pages} &&
-    	    pagespec_match($page, $config{locked_pages},
-    		    user => $session->param("name"),
-    		    ip => $ENV{REMOTE_ADDR},
-    	    )) {
-    		return sprintf(gettext("%s is locked and cannot be edited"),
-    			htmllink("", "", $page, noimageinline => 1));
-    	}
-    
-    	return undef;
-    }
+> That was added because the most typical reason for being unable to edit a
+> page is that you are not logged in. And without the jump to logging the
+> user in, there is no way for the user to log in, without navigating away
+> from the page they were trying to edit. --[[Joey]] 
+
+>> Ok, but the problem is that when you don't want any signin form you end up
+>> with a lone login button. That might happend if you lock pages only on IP
+>> adresses, if you use another cookie from another webapp...
+
+>> That happends to me and I had to reimplement lockedit in my private auth
+>> plugin.
+
+>> Perhaps you could return undef on that case and let another plugin do the
+>> needsignin call ? -- [[Jogo]]