X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/a1d7aad40119cd3f2bc970fc7ce10625d0da7106..84db5e34c5705414e3d5d888f85cb9229fe6be8d:/IkiWiki/Plugin/osm.pm?ds=sidebyside
diff --git a/IkiWiki/Plugin/osm.pm b/IkiWiki/Plugin/osm.pm
index 47c752881..c9c5646c4 100644
--- a/IkiWiki/Plugin/osm.pm
+++ b/IkiWiki/Plugin/osm.pm
@@ -34,8 +34,8 @@ sub getsetup () {
},
osm_default_icon => {
type => "string",
- example => "/ikiwiki/images/osm.png",
- description => "the icon shon on links and on the main map",
+ example => "ikiwiki/images/osm.png",
+ description => "the icon shown on links and on the main map",
safe => 0,
rebuild => 1,
},
@@ -56,17 +56,7 @@ sub getsetup () {
osm_tag_default_icon => {
type => "string",
example => "icon.png",
- description => "the icon attached to a tag so that pages tagged with that tag will have that icon on the map",
- safe => 0,
- rebuild => 1,
- },
- osm_tag_icons => {
- type => "string",
- example => {
- 'test' => '/img/test.png',
- 'trailer' => '/img/trailer.png'
- },
- description => "tag to icon mapping, leading slash is important!",
+ description => "the icon attached to a tag, displayed on the map for tagged pages",
safe => 0,
rebuild => 1,
},
@@ -74,33 +64,22 @@ sub getsetup () {
sub preprocess {
my %params=@_;
- my $page = $params{'page'};
- my $dest = $params{'destpage'};
- my $loc = $params{'loc'}; # sanitized below
- my $lat = $params{'lat'}; # sanitized below
- my $lon = $params{'lon'}; # sanitized below
- my $href = $params{'href'};
+ my $page = $params{page};
+ my $dest = $params{destpage};
+ my $loc = $params{loc}; # sanitized below
+ my $lat = $params{lat}; # sanitized below
+ my $lon = $params{lon}; # sanitized below
+ my $href = $params{href};
- my $fullscreen = defined($params{'fullscreen'}); # sanitized here
my ($width, $height, $float);
- if ($fullscreen) {
- $height = '100%';
- $width = '100%';
- $float = 0;
- }
- else {
- $height = scrub($params{'height'} || "300px", $page, $dest); # sanitized here
- $width = scrub($params{'width'} || "500px", $page, $dest); # sanitized here
- $float = (defined($params{'right'}) && 'right') || (defined($params{'left'}) && 'left'); # sanitized here
- }
+ $height = scrub($params{'height'} || "300px", $page, $dest); # sanitized here
+ $width = scrub($params{'width'} || "500px", $page, $dest); # sanitized here
+ $float = (defined($params{'right'}) && 'right') || (defined($params{'left'}) && 'left'); # sanitized here
+
my $zoom = scrub($params{'zoom'} // $config{'osm_default_zoom'} // 15, $page, $dest); # sanitized below
my $map;
- if ($fullscreen) {
- $map = $params{'map'} || $page;
- }
- else {
- $map = $params{'map'} || 'map';
- }
+ $map = $params{'map'} || 'map';
+
$map = scrub($map, $page, $dest); # sanitized here
my $name = scrub($params{'name'} || $map, $page, $dest);
@@ -111,12 +90,20 @@ sub preprocess {
if ($zoom !~ /^\d\d?$/ || $zoom < 2 || $zoom > 18) {
error("Bad zoom");
}
+
+ if (! defined $href || ! length $href) {
+ $href=IkiWiki::cgiurl(
+ do => "osm",
+ map => $map,
+ );
+ }
+
$pagestate{$page}{'osm'}{$map}{'displays'}{$name} = {
height => $height,
width => $width,
float => $float,
zoom => $zoom,
- fullscreen => $fullscreen,
+ fullscreen => 0,
editable => defined($params{'editable'}),
lat => $lat,
lon => $lon,
@@ -137,7 +124,7 @@ sub process_waypoint {
my $name = scrub($params{'name'} || $p, $page, $dest); # sanitized here
my $desc = scrub($params{'desc'} || '', $page, $dest); # sanitized here
my $zoom = scrub($params{'zoom'} // $config{'osm_default_zoom'} // 15, $page, $dest); # sanitized below
- my $icon = $config{'osm__default_icon'} || "/ikiwiki/images/osm.png"; # sanitized: we trust $config
+ my $icon = $config{'osm_default_icon'} || "ikiwiki/images/osm.png"; # sanitized: we trust $config
my $map = scrub($params{'map'} || 'map', $page, $dest); # sanitized here
my $alt = $config{'osm_alt'} ? "alt=\"$config{'osm_alt'}\"" : ''; # sanitized: we trust $config
if ($zoom !~ /^\d\d?$/ || $zoom < 2 || $zoom > 18) {
@@ -150,46 +137,31 @@ sub process_waypoint {
}
my $tag = $params{'tag'};
- if ($tag) {
- if (!defined($config{'osm_tag_icons'}->{$tag})) {
- error("invalid tag specified, see osm_tag_icons configuration or don't specify any");
+ foreach my $t (keys %{$typedlinks{$page}{'tag'}}) {
+ if ($icon = get_tag_icon($t)) {
+ $tag = $t;
+ last;
}
- $icon = $config{'osm_tag_icons'}->{$tag};
- }
- else {
- foreach my $t (keys %{$typedlinks{$page}{'tag'}}) {
- if ($icon = get_tag_icon($t)) {
- $tag = $t;
- last;
- }
- $t =~ s!/$config{'tagbase'}/!!;
- if ($icon = get_tag_icon($t)) {
- $tag = $t;
- last;
- }
+ $t =~ s!/$config{'tagbase'}/!!;
+ if ($icon = get_tag_icon($t)) {
+ $tag = $t;
+ last;
}
}
- $icon = "/ikiwiki/images/osm.png" unless $icon;
+ $icon = urlto($icon, $dest, 1);
$tag = '' unless $tag;
if ($page eq $dest) {
- if (!defined($config{'osm_format'}) || !$config{'osm_format'}) {
- $config{'osm_format'} = 'KML';
- }
- my %formats = map { $_ => 1 } split(/, */, $config{'osm_format'});
+ my %formats = get_formats();
if ($formats{'GeoJSON'}) {
- will_render($page,$config{destdir} . "/$map/pois.json");
+ will_render($page, "$map/pois.json");
}
if ($formats{'CSV'}) {
- will_render($page,$config{destdir} . "/$map/pois.txt");
+ will_render($page, "$map/pois.txt");
}
if ($formats{'KML'}) {
- will_render($page,$config{destdir} . "/$map/pois.kml");
+ will_render($page, "$map/pois.kml");
}
}
- my $href = "/ikiwiki.cgi?do=osm&map=$map&lat=$lat&lon=$lon&zoom=$zoom";
- if (defined($destsources{htmlpage($map)})) {
- $href = urlto($map,$page) . "?lat=$lat&lon=$lon&zoom=$zoom";
- }
$pagestate{$page}{'osm'}{$map}{'waypoints'}{$name} = {
page => $page,
desc => $desc,
@@ -197,19 +169,28 @@ sub process_waypoint {
tag => $tag,
lat => $lat,
lon => $lon,
- # how to link back to the page from the map, not to be
+ # How to link back to the page from the map, not to be
# confused with the URL of the map itself sent to the
- # embeded map below
- href => urlto($page,$map),
+ # embeded map below. Note: used in generated KML etc file,
+ # so must be absolute.
+ href => urlto($page),
};
+
+ my $mapurl = IkiWiki::cgiurl(
+ do => "osm",
+ map => $map,
+ lat => $lat,
+ lon => $lon,
+ zoom => $zoom,
+ );
my $output = '';
if (defined($params{'embed'})) {
- $params{'href'} = $href; # propagate down to embeded
- $output .= preprocess(%params);
+ $output .= preprocess(%params,
+ href => $mapurl,
+ );
}
if (!$hidden) {
- $href =~ s!&!&!g;
- $output .= "";
+ $output .= "";
}
return $output;
}
@@ -222,10 +203,6 @@ sub get_tag_icon($) {
if (srcfile($attached)) {
return $attached;
}
- # look for the old way: mappings
- if ($config{'osm_tag_icons'}->{$tag}) {
- return $config{'osm_tag_icons'}->{$tag};
- }
else {
return undef;
}
@@ -308,10 +285,7 @@ sub savestate {
}
}
- if (!defined($config{'osm_format'}) || !$config{'osm_format'}) {
- $config{'osm_format'} = 'KML';
- }
- my %formats = map { $_ => 1 } split(/, */, $config{'osm_format'});
+ my %formats = get_formats();
if ($formats{'GeoJSON'}) {
writejson(\%waypoints, \%linestrings);
}
@@ -351,41 +325,6 @@ sub writekml($;$) {
eval q{use XML::Writer};
error $@ if $@;
foreach my $map (keys %waypoints) {
-
-=pod
-Sample placemark:
-
-
-