X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/9ea045e427caf38e2476eb5c85a937a1447ed25c..5c418d269304af618b142e0328742fc7d7157c62:/doc/bugs/Add_a_footer_div_on_all_pages_to_improve_theming.mdwn diff --git a/doc/bugs/Add_a_footer_div_on_all_pages_to_improve_theming.mdwn b/doc/bugs/Add_a_footer_div_on_all_pages_to_improve_theming.mdwn index efd66fbbb..e0dd100fa 100644 --- a/doc/bugs/Add_a_footer_div_on_all_pages_to_improve_theming.mdwn +++ b/doc/bugs/Add_a_footer_div_on_all_pages_to_improve_theming.mdwn @@ -1,43 +1,149 @@ The following patch adds a footer div on all pages to ease CSS themeing. Indeed, the misc.tmpl, recentchanges.tmpl and editpage.tmpl templates lack such a div. -This patch is against current svn. +> So, the problem with this is that the default css inserts a horizontal +> line at the top of the footer div, and putting an empty footer on these +> other pages looks a bit weird. Any idea how to get around that? +> --[[Joey]] + +>> Sorry I didn't see that. It definitely looks weird. We could add text +>> in all footers or change the CSS stylesheet, but it's not clean IMHO. + +>> The idea was about to ease themeing by giving all the pages the same +>> structure. The current structure is the following one: + +>> div header - div actions ... div content - div footer (sometimes) + +>> So we could add some new divs in all templates. By default, they will +>> be empty and no CSS will be defined for them. This way ikiwiki +>> standard appearance is not changed but themeing will be eased. +>> The new page structure could be: + +>> * div banner (to show up a logo for example) + +>> * div content-wrap containing div header, div actions, ... div content +>> and div footer + +>> * div realfooter (to put credits, "Powered by ikiwiki", "Valid XHTML"...) + +>> From my tests, it works: Just adding the divs, without touching the stylesheet, +>> doesn't change ikiwiki appearance. And themeing is eased :-) + +>> I can update the patch, if you want to follow and test this idea. --Fred + +>>> Sure, go ahead --[[Joey]] + +>>>>Here is an updated patch against current svn. --Fred Index: templates/recentchanges.tmpl =================================================================== - --- templates/recentchanges.tmpl (révision 3543) + --- templates/recentchanges.tmpl (révision 3575) +++ templates/recentchanges.tmpl (copie de travail) - @@ -64,6 +64,8 @@ - + @@ -12,7 +12,11 @@ + + +
+ + + + +