X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/97898ce585b36dbcb0a83356ef3e54c41d369437..bab8fec52468b780485bdf96a37a593bd033c7e3:/doc/todo/allow_site-wide_meta_definitions.mdwn diff --git a/doc/todo/allow_site-wide_meta_definitions.mdwn b/doc/todo/allow_site-wide_meta_definitions.mdwn index e4638f94b..7129a44ac 100644 --- a/doc/todo/allow_site-wide_meta_definitions.mdwn +++ b/doc/todo/allow_site-wide_meta_definitions.mdwn @@ -212,6 +212,9 @@ definitions essentially. >>> Hopefully I'll be back in the mix soon, too. In the meantime, Joey, have >>> you had a chance to look at this yet? -- [[Jon]] +>>>> Ping :) Hi. [[Joey]], would you consider this patch for the next +>>>> ikiwiki release? -- [[Jon]] + >>> For this to work with websetup and --dumpsetup, it needs to define the >>> `meta_*` settings in the getsetup function. >>> @@ -219,7 +222,7 @@ definitions essentially. >>> a lot of redundant data at meta, which then stores it in a very redundant >>> way. Specifically, meta populates a per-page `%metaheaders` hash >>> as well as storing per-page metadata in `%pagestate`. So, if you have ->>> a wiki with a thousand pages, and you add a 1k site-wide license text, +>>> a wiki with 10 thousand pages, and you add a 1k site-wide license text, >>> that will bloat the memory usage of ikiwiki by in excess of 2 >>> megabytes. It will also cause ikiwiki to write a similar amount more data >>> to its state file which has to be loaded back in each @@ -229,3 +232,6 @@ definitions essentially. >>> meta special-case the site-wide settings, not store them in these >>> per-page data structures, and just make them be used if no per-page >>> metadata of the given type is present. --[[Joey]] + +>>>> Thanks for the review - these are all valid points. I'll get working +>>>> on a revised patch. -- [[Jon]]