X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/93c6d2c340b9529eedf611d6e753030cc9c29ae9..bc79a6d50398a9718f15cf2247e24c429ab4a30e:/IkiWiki/CGI.pm
diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index b1caff96d..788d0487e 100644
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -20,6 +20,24 @@ sub printheader ($) { #{{{
}
} #}}}
+
+sub showform ($$$$) { #{{{
+ my $form=shift;
+ my $buttons=shift;
+ my $session=shift;
+ my $cgi=shift;
+
+ if (exists $hooks{formbuilder}) {
+ run_hooks(formbuilder => sub {
+ shift->(form => $form, cgi => $cgi, session => $session,
+ buttons => $buttons);
+ });
+ }
+ else {
+ printheader($session);
+ print misctemplate($form->title, $form->render(submit => $buttons));
+ }
+}
sub redirect ($$) { #{{{
my $q=shift;
@@ -137,7 +155,7 @@ sub cgi_signin ($$) { #{{{
error($@) if $@;
my $form = CGI::FormBuilder->new(
title => "signin",
- header => 1,
+ name => "signin",
charset => "utf-8",
method => 'POST',
required => 'NONE',
@@ -145,7 +163,7 @@ sub cgi_signin ($$) { #{{{
params => $q,
action => $config{cgiurl},
header => 0,
- template => scalar template_params("signin.tmpl"),
+ template => {type => 'div'},
stylesheet => baseurl()."style.css",
);
my $buttons=["Login"];
@@ -156,25 +174,18 @@ sub cgi_signin ($$) { #{{{
$form->field(name => "do", type => "hidden", value => "signin",
force => 1);
+ decode_form_utf8($form);
+
run_hooks(formbuilder_setup => sub {
- shift->(form => $form, cgi => $q, session => $session);
+ shift->(form => $form, cgi => $q, session => $session,
+ buttons => $buttons);
});
-
- decode_form_utf8($form);
- if (exists $hooks{formbuilder}) {
- run_hooks(formbuilder => sub {
- shift->(form => $form, cgi => $q, session => $session,
- buttons => $buttons);
- });
- }
- else {
- if ($form->submitted) {
- $form->validate;
- }
- printheader($session);
- print misctemplate($form->title, $form->render(submit => $buttons));
+ if ($form->submitted) {
+ $form->validate;
}
+
+ showform($form, $buttons, $session, $q);
} #}}}
sub cgi_postsignin ($$) { #{{{
@@ -206,6 +217,7 @@ sub cgi_prefs ($$) { #{{{
error($@) if $@;
my $form = CGI::FormBuilder->new(
title => "preferences",
+ name => "preferences",
header => 0,
charset => "utf-8",
method => 'POST',
@@ -216,7 +228,7 @@ sub cgi_prefs ($$) { #{{{
javascript => 0,
params => $q,
action => $config{cgiurl},
- template => scalar template_params("prefs.tmpl"),
+ template => {type => 'div'},
stylesheet => baseurl()."style.css",
fieldsets => [
[login => gettext("Login")],
@@ -226,8 +238,11 @@ sub cgi_prefs ($$) { #{{{
);
my $buttons=["Save Preferences", "Logout", "Cancel"];
+ decode_form_utf8($form);
+
run_hooks(formbuilder_setup => sub {
- shift->(form => $form, cgi => $q, session => $session);
+ shift->(form => $form, cgi => $q, session => $session,
+ buttons => $buttons);
});
$form->field(name => "do", type => "hidden");
@@ -254,8 +269,6 @@ sub cgi_prefs ($$) { #{{{
}
}
- decode_form_utf8($form);
-
if ($form->submitted eq 'Logout') {
$session->delete();
redirect($q, $config{url});
@@ -281,16 +294,7 @@ sub cgi_prefs ($$) { #{{{
$form->text(gettext("Preferences saved."));
}
- if (exists $hooks{formbuilder}) {
- run_hooks(formbuilder => sub {
- shift->(form => $form, cgi => $q, session => $session,
- buttons => $buttons);
- });
- }
- else {
- printheader($session);
- print misctemplate($form->title, $form->render(submit => $buttons));
- }
+ showform($form, $buttons, $session, $q);
} #}}}
sub cgi_editpage ($$) { #{{{
@@ -303,8 +307,8 @@ sub cgi_editpage ($$) { #{{{
eval q{use CGI::FormBuilder};
error($@) if $@;
my $form = CGI::FormBuilder->new(
+ title => "editpage",
fields => \@fields,
- header => 1,
charset => "utf-8",
method => 'POST',
validate => {
@@ -314,21 +318,25 @@ sub cgi_editpage ($$) { #{{{
javascript => 0,
params => $q,
action => $config{cgiurl},
+ header => 0,
table => 0,
template => scalar template_params("editpage.tmpl"),
+ wikiname => $config{wikiname},
);
+ decode_form_utf8($form);
+
run_hooks(formbuilder_setup => sub {
- shift->(form => $form, cgi => $q, session => $session);
+ shift->(form => $form, cgi => $q, session => $session,
+ buttons => \@buttons);
});
- decode_form_utf8($form);
-
# This untaint is safe because titlepage removes any problematic
# characters.
my ($page)=$form->field('page');
$page=titlepage(possibly_foolish_untaint($page));
- if (! defined $page || ! length $page || file_pruned($page, $config{srcdir}) || $page=~/^\//) {
+ if (! defined $page || ! length $page ||
+ file_pruned($page, $config{srcdir}) || $page=~/^\//) {
error("bad page name");
}
@@ -394,19 +402,27 @@ sub cgi_editpage ($$) { #{{{
return;
}
elsif ($form->submitted eq "Preview") {
+ my $content=$form->field('editcontent');
+ run_hooks(editcontent => sub {
+ $content=shift->(
+ content => $content,
+ page => $page,
+ cgi => $q,
+ session => $session,
+ );
+ });
$form->tmpl_param("page_preview",
htmlize($page, $type,
linkify($page, "",
preprocess($page, $page,
- filter($page, $form->field('editcontent')), 0, 1))));
+ filter($page, $page, $content), 0, 1))));
}
- else {
+ elsif ($form->submitted eq "Save Page") {
$form->tmpl_param("page_preview", "");
}
$form->tmpl_param("page_conflict", "");
- if (! $form->submitted || $form->submitted eq "Preview" ||
- ! $form->validate) {
+ if ($form->submitted ne "Save Page" || ! $form->validate) {
if ($form->field("do") eq "create") {
my @page_locs;
my $best_loc;
@@ -469,6 +485,7 @@ sub cgi_editpage ($$) { #{{{
$form->field(name => "type", type => 'select',
options => \@page_types);
$form->title(sprintf(gettext("creating %s"), pagetitle($page)));
+
}
elsif ($form->field("do") eq "edit") {
check_canedit($page, $q, $session);
@@ -488,24 +505,27 @@ sub cgi_editpage ($$) { #{{{
$form->title(sprintf(gettext("editing %s"), pagetitle($page)));
}
- print $form->render(submit => \@buttons);
+ showform($form, \@buttons, $session, $q);
+ saveindex();
}
else {
# save page
check_canedit($page, $q, $session);
- if (! -e "$config{srcdir}/$file" &&
- $form->field("do") ne "create") {
+
+ my $exists=-e "$config{srcdir}/$file";
+
+ if ($form->field("do") ne "create" && ! $exists &&
+ ! eval { srcfile($file) }) {
$form->tmpl_param("page_gone", 1);
$form->field(name => "do", value => "create", force => 1);
$form->tmpl_param("page_select", 0);
$form->field(name => "page", type => 'hidden');
$form->field(name => "type", type => 'hidden');
$form->title(sprintf(gettext("editing %s"), $page));
- print $form->render(submit => \@buttons);
+ showform($form, \@buttons, $session, $q);
return;
}
- elsif (-e "$config{srcdir}/$file" &&
- $form->field("do") eq "create") {
+ elsif ($form->field("do") eq "create" && $exists) {
$form->tmpl_param("creation_conflict", 1);
$form->field(name => "do", value => "edit", force => 1);
$form->tmpl_param("page_select", 0);
@@ -516,12 +536,19 @@ sub cgi_editpage ($$) { #{{{
value => readfile("$config{srcdir}/$file").
"\n\n\n".$form->field("editcontent"),
force => 1);
- print $form->render(submit => \@buttons);
+ showform($form, \@buttons, $session, $q);
return;
}
my $content=$form->field('editcontent');
-
+ run_hooks(editcontent => sub {
+ $content=shift->(
+ content => $content,
+ page => $page,
+ cgi => $q,
+ session => $session,
+ );
+ });
$content=~s/\r\n/\n/g;
$content=~s/\r/\n/g;
@@ -538,7 +565,7 @@ sub cgi_editpage ($$) { #{{{
$form->field(name => "page", type => 'hidden');
$form->field(name => "type", type => 'hidden');
$form->title(sprintf(gettext("editing %s"), $page));
- print $form->render(submit => \@buttons);
+ showform($form, \@buttons, $session, $q);
return;
}
@@ -550,7 +577,7 @@ sub cgi_editpage ($$) { #{{{
$message=$form->field('comments');
}
- if ($form->field("do") eq "create") {
+ if (! $exists) {
rcs_add($file);
}
@@ -569,6 +596,10 @@ sub cgi_editpage ($$) { #{{{
# may have been committed while the post-commit hook was
# disabled.
require IkiWiki::Render;
+ # Reload index, since the first time it's loaded is before
+ # the wiki is locked, and things may have changed in the
+ # meantime.
+ loadindex();
refresh();
saveindex();
@@ -582,7 +613,7 @@ sub cgi_editpage ($$) { #{{{
$form->field(name => "page", type => 'hidden');
$form->field(name => "type", type => 'hidden');
$form->title(sprintf(gettext("editing %s"), $page));
- print $form->render(submit => \@buttons);
+ showform($form, \@buttons, $session, $q);
return;
}
else {
@@ -645,9 +676,6 @@ sub cgi (;$$) { #{{{
cgi_recentchanges($q);
return;
}
- elsif ($do eq 'hyperestraier') {
- cgi_hyperestraier();
- }
# Need to lock the wiki before getting a session.
lockwiki();
@@ -681,7 +709,10 @@ sub cgi (;$$) { #{{{
print gettext("You are banned.");
cgi_savesession($session);
}
- elsif ($do eq 'signin') {
+
+ run_hooks(sessioncgi => sub { shift->($q, $session) });
+
+ if ($do eq 'signin') {
cgi_signin($q, $session);
cgi_savesession($session);
}
@@ -694,21 +725,6 @@ sub cgi (;$$) { #{{{
elsif ($do eq 'create' || $do eq 'edit') {
cgi_editpage($q, $session);
}
- elsif ($do eq 'blog') {
- my $page=decode_utf8($q->param('title'));
- $page=~s/\///g; # no slashes in blog posts
- # if the page already exists, munge it to be unique
- my $from=$q->param('from');
- my $add="";
- while (exists $pagecase{lc($from."/".titlepage($page).$add)}) {
- $add=1 unless length $add;
- $add++;
- }
- $q->param('page', $page.$add);
- # now run same as create
- $q->param('do', 'create');
- cgi_editpage($q, $session);
- }
elsif ($do eq 'postsignin') {
error(gettext("login failed, perhaps you need to turn on cookies?"));
}