X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/91f7fbe09f11303f7a798a491dff0dd229059884..2cb0bb432daa612d928de543e74927755094450d:/doc/plugins/comments/discussion.mdwn diff --git a/doc/plugins/comments/discussion.mdwn b/doc/plugins/comments/discussion.mdwn index ceb02406d..0641ddcc9 100644 --- a/doc/plugins/comments/discussion.mdwn +++ b/doc/plugins/comments/discussion.mdwn @@ -227,3 +227,31 @@ use those formats because it would be a security problem. Any suggestions or hints how to implement this? -- [[wentasah]] + +> I've implemented this. See [[todo/Restrict_formats_allowed_for_comments]]. +> --[[wentasah]] + +## URLs in anonymous-style comments committed directly via VCS + +[[!template id=gitbranch branch=schmonz/comments-anonymous-url-vcs author="[[schmonz]]"]] + +I recently imported my site from Textpattern into ikiwiki (using +an `ikiwiki-import` program that may someday make its way into +ikiwiki proper). Textpattern's comments behave much like ikiwiki's +anonymous comments, so piping each imported comment through +`ikiwiki-comment` and regenerating the site with `comments_allowauthor=1` +preserved almost all the information. + +What's missing: if a comment directive has a `url` param, I'd expect +the rendered page to href the author's name to that URL. This works +as I expect for new comments added via the CGI, but not for imported +comments added via the VCS directly. + +My branch has a fix that doesn't break `t/comments.t`, doesn't +appear to break anonymous or signed-in comments via the CGI in any +way I've tried, and lets me render my (incredibly valuable ;-) +imported blog comments with full fidelity. OK to commit? + +> Ship it. --[[smcv]] + +>> Thanks, have done. --[[schmonz]]