X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/912521ef0711204965aa2319d41c7741bd3f4f4c..aab415481de28a7ca3baa7e7d5ba168e962f61e0:/IkiWiki/Plugin/smiley.pm?ds=sidebyside

diff --git a/IkiWiki/Plugin/smiley.pm b/IkiWiki/Plugin/smiley.pm
index 85a719337..a8fed69e1 100644
--- a/IkiWiki/Plugin/smiley.pm
+++ b/IkiWiki/Plugin/smiley.pm
@@ -3,27 +3,37 @@ package IkiWiki::Plugin::smiley;
 
 use warnings;
 use strict;
-use IkiWiki;
+use IkiWiki 2.00;
 
 my %smileys;
 my $smiley_regexp;
 
 sub import { #{{{
-	hook(type => "checkconfig", id => "smiley", call => \&setup);
+	add_underlay("smiley");
+	hook(type => "sanitize", id => "smiley", call => \&sanitize);
 } # }}}
 
-sub setup () { #{{{
+sub build_regexp () { #{{{
 	my $list=readfile(srcfile("smileys.mdwn"));
 	while ($list =~ m/^\s*\*\s+\\([^\s]+)\s+\[\[([^]]+)\]\]/mg) {
-		$smileys{$1}=$2;
+		my $smiley=$1;
+		my $file=$2;
+
+		$smileys{$smiley}=$file;
+
+		# Add a version with < and > escaped, since they probably
+		# will be (by markdown) by the time the sanitize hook runs.
+		$smiley=~s/</&lt;/g;
+		$smiley=~s/>/&gt;/g;
+		$smileys{$smiley}=$file;
 	}
 	
 	if (! %smileys) {
-		debug(gettext("failed to parse any smileys, disabling plugin"));
+		debug(gettext("failed to parse any smileys"));
+		$smiley_regexp='';
 		return;
 	}
 	
-	hook(type => "filter", id => "smiley", call => \&filter);
 	# sort and reverse so that substrings come after longer strings
 	# that contain them, in most cases.
 	$smiley_regexp='('.join('|', map { quotemeta }
@@ -31,14 +41,47 @@ sub setup () { #{{{
 	#debug($smiley_regexp);
 } #}}}
 
-sub filter (@) { #{{{
+sub sanitize (@) { #{{{
 	my %params=@_;
+
+	build_regexp() unless defined $smiley_regexp;
 	
-	$params{content} =~ s{(?<=\s)(\\?)$smiley_regexp(?=\s)}{
-		$1 ? $2 : htmllink($params{page}, $params{page}, $smileys{$2}, 0, 0, $2)
-	}egs;
+	$_=$params{content};
+	return $_ unless length $smiley_regexp;
 	
-	return $params{content};
+MATCH:	while (m{(?:^|(?<=\s|>))(\\?)$smiley_regexp(?:(?=\s|<)|$)}g) {
+		my $escape=$1;
+		my $smiley=$2;
+		my $epos=$-[1];
+		my $spos=$-[2];
+		
+		# Smilies are not allowed inside <pre> or <code>.
+		# For each tag in turn, match forward to find the next <tag>
+		# or </tag> after the smiley.
+		my $pos=pos;
+		foreach my $tag ("pre", "code") {
+			if (m/<(\/)?\s*$tag\s*>/isg && defined $1) {
+				# </tag> found first, so the smiley is
+				# inside the tag, so do not expand it.
+				next MATCH;
+			}
+			# Reset pos back to where it was before this test.
+			pos=$pos;
+		}
+
+		if ($escape) {
+			# Remove escape.
+			substr($_, $epos, 1)="";
+		}
+		else {
+			# Replace the smiley with its expanded value.
+			substr($_, $spos, length($smiley))=
+				htmllink($params{page}, $params{page},
+				         $smileys{$smiley}, linktext => $smiley);
+		}
+	}
+
+	return $_;
 } # }}}
 
 1