X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/8f67b981cd89d146fec158b3be819e6f9c48e1f7..041e3c3c5dd3333304c21c0a8145986014544a7d:/doc/todo/admonitions.mdwn diff --git a/doc/todo/admonitions.mdwn b/doc/todo/admonitions.mdwn index 0f479019c..16f0b00ee 100644 --- a/doc/todo/admonitions.mdwn +++ b/doc/todo/admonitions.mdwn @@ -118,4 +118,53 @@ bangs and all... [admon-caution.png]: https://moinmo.in/moin_static19/modernized/img/admon-caution.png Update: I have made a [[plugins/contrib/admonition]] plugin for this -purpose, as a patch. Hopefully it will be mergeable here? +purpose, as a patch. Hopefully it will be mergeable here? Here's a +screenshot of what the help page would look like, to give you an idea +of the results: + + + +--- + +I like the idea of admonitions. I've done something vaguely similar on my own site ([e.g.](https://jmtd.net/film/blade_runner/)), but I just +use `\[[!template` and put up with the verbosity.I like that `\[[!tip` is shorter than `\[[!template id=…`. If +I was being a total purist I'd argue that the correct change would be to make a syntax shortcut +for the template syntax, since functionally that's what `tip` is doing, and include the +admonition styles in either `style.css` or in every shipped theme. But I'm more of a pragmatist +and your current plugin actually exists and IkiWiki is starving for contributors (IMHO) +so I encourage maintainers to merge it. I will probably merge it into [opinionated ikiwiki](https://jmtd.net/log/opinionated_ikiwiki/) +in either case (which will at least mean there'll be another avenue for people to check it out) *— [[Jon]], 2020-08-07* + +> One quick tip/request, [[anarcat]]: If you could update the "master" branch in your IkiWiki +> fork to match the merge base for your branches, it would be easy to use Gitlab's "compare" +> feature in-browser to see a combined diff of your changes. *— [[Jon]], 2020-08-07* + +> > Thanks for your support and comments! :) I don't have the time to manage another extra branch on top of the stack I already have unfortunately. but it might be simpler for me in the future... I keep on hoping all patches get merged and that i don't need to (more officially) fork `master`, but it seems that's where I need to go myself... In the meantime you can see the list of patches I maintain in [[users/anarcat]] and [my maintenance log](https://anarc.at/services/wiki/). I hope that helps! -- [[anarcat]] + +> > Turns out I found the time. I merged all my active branches in the `master` branch on gitlab. not sure what you'd compare it against, but there, it's done. :) [[anarcat]] + +>>> Thanks for that! I'll try to explain what I meant in terms of an example. your `admonitions` is a series of commits that ultimately sit on top of +>>> upstream's `d0099568` ("Prepare release for unstable"). If I want to see a quick combined diff of all the changes made in that branch, I can try to +>>> use GitLab's "Compare" feature, but it does not let me specify a SHA to compare against, only a ref-name such as (your) `master`, which (at the time) +>>> was a much earlier commit than `d0099568`, so "Compare" would include all the unrelated upstream changes. If instead either `master` was `d0099568`, or +>>> `admonitions` was rebased on top of whatever your `master` was, then GitLab's "Compare" would be useful. As it is, I cloned locally and did the necessary +>>> `git` incantation. *— [[Jon]], 2020-08-12* + +>>>> I have rebased all my current branches onto `debian/3.20190228-1` because that's what I'm patching in production, and I have updated my `master` branch on GitLab to follow that. The branches are admonitions, [bootstrap-plugin](https://ikiwiki.info/plugins/contrib/bootstrap), [toc-skip](https://ikiwiki.info/todo/allow_toc_to_skip_entries), [page-template-variable](https://ikiwiki.info/todo/include_page_variable_in_base_templates), [js-newline](https://ikiwiki.info/bugs/javascript_resources_placed_after_html_tag/), [i18n-headinganchors](https://ikiwiki.info/plugins/contrib/i18nheadinganchors), [dev/git-annex-support](https://ikiwiki.info/todo/git-annex_support/), and [geo-scheme](https://ikiwiki.info/todo/add_geo_uri_scheme/). Phew. Is that what you needed? It's still kind of a mess, but it should make it easier for you to review... --[[anarcat]] + +---- + +I've finally started playing around with this plugin. I think the default CSS needs +tweaking. I see "warning" has `padding` to try to account for the icon size, but +the other admonitions do not. Perhaps they need to inherit some style from a common +class? Either way, the padding does not seem to work. This is a fresh ikiwiki with +the actiontab theme enabled: + +pic demoing admonitions +*— [[Jon]], 2021-02-15* + +> I had kind of given up on this guy here, to be honest, but if you want to see a working version, you can look at [my sandbox](https://anarc.at/sandbox/). Obviously, the CSS does need more tweaking, but it seems it's not my specialty. ;) -- [[anarcat]] + +>> It turned out to be a simple fix, a missing semicolon. [patch here](https://github.com/jmtd/ikiwiki/commit/3e31200ed258ba1f7ab1652d6bc2d035a9e5c990). The rest of that branch is just your admonitions branch rebased onto `3.20200202.3`. *—[[Jon]], 2021-02-18* + +>>> Interesting. That was of course, a missing semicolon, not sure how I missed that. I cherry-picked your patch, but I wonder why I wasn't seeing the problem on my end... Maybe I had other padding that was covering for this... Thanks, in any case! :) -- [[anarcat]]