X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/8e2f7ec70f257d262f08877b3a17caafcf5184ce..6d8fd9bf0d9a901e3f62086ac625c43f047ae72a:/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn?ds=sidebyside diff --git a/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn b/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn index 4d6506657..eb95e9992 100644 --- a/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn +++ b/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn @@ -1,17 +1,22 @@ -The final `` in [`recentchanges.tmpl`][tmpl] gets wrapped in a +The final `` in `recentchanges.tmpl` gets wrapped in a `
` tag for some reason, resulting in the following invalid XHTML at the end of the [[RecentChanges]] page
+> I'll bet this is fixed if you use the markdown 1.2 prerelease, which has +> a much less buggy html parser. (Ah, I see below that was the case.) +> --[[Joey]] + Also, there is a problem with the `` tags generated by the smiley plugin which end up wrapped in a `` tag in the inline diff output. `` tags is not allowed within a `` block. Maybe the smiley plugin should be disabled on [[RecentChanges]]? +> See [[Smileys_in_the_block_code]], which is now fixed. --[[Joey]] + See the [validator output][validate] for more details. - [tmpl]: http://git.ikiwiki.info/?p=ikiwiki;a=blob_plain;f=templates/recentchanges.tmpl;hb=HEAD [validate]: http://validator.w3.org/check?uri=http://ikiwiki.info/recentchanges/ - - - @@ -31,24 +36,10 @@ processing and throw an error. —[Jason Blevins](http://jblevins.org/) Here is a simple patch for the refresh problem. I haven't figured out what's causing the recentchanges bug yet. - - diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm - index 8a9a538..0afe1c3 100644 - --- a/IkiWiki/Plugin/meta.pm - +++ b/IkiWiki/Plugin/meta.pm - @@ -186,7 +186,7 @@ sub preprocess (@) { #{{{ - $value=encode_entities($value); - } - my $delay=int(exists $params{delay} ? $params{delay} : 0); - - my $redir=""; - + my $redir=""; - if (! $safe) { - $redir=scrub($redir); - } - - --[[JasonBlevins]] +> Thanks, applied that patch. --[[Joey]] + - - - It turns out that the invalid XHTML on the recent changes page is due to @@ -59,4 +50,6 @@ after installing the most recent version of Text::Markdown from CPAN. Note that the above patch for the redirect tag is still applicable and the smiley issue remains open. --[[JasonBlevins]] -[[tag patch]] +> This bug is [[done]], all issues are fixed. --[[Joey]] + +[[!tag patch]]