X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/8cac2ac23eac0026faf4054c1ffda459be4a2bd3..cc5cd88d3e5d0ebc5ac7601d0bfb6374a196ecb4:/doc/bugs/attachment:_failed_to_get_filehandle.mdwn?ds=sidebyside

diff --git a/doc/bugs/attachment:_failed_to_get_filehandle.mdwn b/doc/bugs/attachment:_failed_to_get_filehandle.mdwn
index 676918831..acfc60078 100644
--- a/doc/bugs/attachment:_failed_to_get_filehandle.mdwn
+++ b/doc/bugs/attachment:_failed_to_get_filehandle.mdwn
@@ -44,7 +44,7 @@ the error message like below:
 >>>>>>     $CGI::VERSION='3.15';
 
 >>>>> I've just checked in a fix that should work, can you test it?
->>>>> [diff](http://git.ikiwiki.info/?p=ikiwiki;a=commitdiff;h=71f10579c00a8ddc20ada1a1efd33aac25a3da7e) --[[Joey]]
+>>>>> 71f10579c00a8ddc20ada1a1efd33aac25a3da7e --[[Joey]]
 
 >>>>>> I've patched `attachment.pm` module, but the bug still occurs.
 >>>>>> However I can see a little progress. I changed invoking `error()`
@@ -63,7 +63,7 @@ the error message like below:
 >>>>>>> though. I've checked in a second try at dealing with things, can
 >>>>>>> you try it? --[[Joey]]
 
->>>>>>>> Do you mean that [diff](http://git.ikiwiki.info/?p=ikiwiki;a=commitdiff;h=66f35e30dcea03c631a293e2341771277543b4ae)?
+>>>>>>>> Do you mean that 66f35e30dcea03c631a293e2341771277543b4ae?
 >>>>>>>> If so, then it causes "Internal Server Error" for me:
 
 >>>>>>>>     Can't use string ("test.txt") as a symbol ref while "strict refs" in use at /usr/share/perl5/IkiWiki/Plugin/attachment.pm line 144.
@@ -79,6 +79,17 @@ the error message like below:
 >>>>>>>>>> Do you have any another idea how to resolve that problem? I can try with rebuilding
 >>>>>>>>>> package `perl-modules` if it's necessary in that situation. --[[Paweł|ptecza]]
 
+>>>>>>>>>>> If CGI.pm is not creating a temp file, not providing a
+>>>>>>>>>>> filehandle by either of its documented methods, then it's just
+>>>>>>>>>>> broken; ikiwiki can't deal with that level of brokennecess.
+>>>>>>>>>>> I need to find out if this affects stable in general, or just
+>>>>>>>>>>> you/ubuntu. --[[Joey]]
+
+>>>>>>>>>>>> Same thing on FreeBSD using CGI.pm 3.15. Looks like $self->{'.tmpfiles'} in CGI.pm
+>>>>>>>>>>>> is not populated with the information about the uploaded file, causing tmpFileName()
+>>>>>>>>>>>> to return '' (unloadInfo(), which uses the same lookup method fails in the same manner),
+>>>>>>>>>>>> but I have yet to find out why this happens. --[[HenrikBrixAndersen]]
+
 The same message I can see in the Apache log file. There is also
 following warning:
 
@@ -88,6 +99,17 @@ following warning:
 
 Is it Ikiwiki bug or my attachment plugin is misconfigured? --[[Paweł|ptecza]]
 
-> Joey, please fix the colon in page name of my report. [...]
+> I've reproduced the bug, and it does seem to be a bug with the perl in
+> debian stable/ubuntu hardy. Trying to figure it out --[[Joey]]
+
+> This was amazingly disgusting, see commit message for the full horror of
+> the details. I think it's [[done]] -- at least it works on debian stable
+> now. --[[Joey]]
+
+>> Wow! It's probably the biggest Ikiwiki commit message I've ever seen :)
+
+>> Yes, I can confirm that now the plugin works for me and I'm able to add
+>> attachments to my wiki. Yupiii! :D
+>> Thanks a lot, Joey! You're really great! :) --[[Paweł|ptecza]]
 
->> Moved to [[colon:problem]] --[[Joey]]
+>> Thank you very much for your effort, Joey! :) --[[Paweł|ptecza]]