X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/82fe20c7cbce09ecd3c213705a4d945b59ad328d..687f7f7b77d72e6e6ad6aa5f2323894cc87c1366:/doc/bugs/table_can_not_deal_with_Chinese_.mdwn

diff --git a/doc/bugs/table_can_not_deal_with_Chinese_.mdwn b/doc/bugs/table_can_not_deal_with_Chinese_.mdwn
index d9ca6ec1f..f115fbebb 100644
--- a/doc/bugs/table_can_not_deal_with_Chinese_.mdwn
+++ b/doc/bugs/table_can_not_deal_with_Chinese_.mdwn
@@ -80,7 +80,60 @@ The below patch seem to deal with this problem:
      			debug(sprintf(gettext('parse fail at line %d: %s'), 
     -- 
     2.19.0
-    
 
-    
+> Thanks, I've applied that patch and added test coverage. [[done]] --[[smcv]]
+
+----
+
+I can confirm that the above patch fixes the issue for me. Thanks! I'm not an ikiwiki committer, but I would encourage them to consider the above. Whilst I'm at it, I would be *really* grateful for some input on [[todo/support_multi-row_table_headers]] which relates to the same plugin. [[Jon]]
+
+----
 
+I've hit this bug with an inline-table and 3.20190228-1 (so: patch applied), with the following definition
+
+    [[\!table class=fullwidth_table delimiter="      " data="""    
+     
+    Number  Title   Own?    Read?    
+    I (HB1), 70 (PB1), 5 (PB50)     Dune    O       ✓"""]]
+
+I'm going to attempt to work around it by moving to an external CSV. ­— [[Jon]]
+
+> What version of Text::CSV (Debian: `libtext-csv-perl`) are you using?
+> What version of Text::CSV::XS (Debian: `libtext-csv-xs-perl`) are you
+> using, if any?
+>
+> I could't reproduce this with `libtext-csv-perl_2.00-1` and
+> `libtext-csv-xs-perl_1.39-1`, assuming that the whitespace in
+> `delimiter="..."` was meant to be a literal tab character, and that
+> the data row has literal tabs before Dune, before O and before ✓.
+>
+> It would be great if you could modify `t/table.t` to include a failing
+> test-case, and push it to your github fork or something, so I can apply
+> it without having to guess precisely what the whitespace should be.
+> --[[smcv]]
+
+>> Sorry, I appreciate as bug reports go my last post was not that useful.
+>> It's serving as a sort-of personal placeholder to investigate further.
+>> The issue can be seen live [here](https://jmtd.net/fiction/sf_masterworks/),
+>> the source is [here](https://jmtd.net/tmp/sf_masterworks.mdwn). The web
+>> servers versions are ikiwiki                  3.20190228-1,
+>> libtext-csv-perl         1.33-2 and libtext-csv-xs-perl is not installed.
+>> I'll do some futher diagnosis and poking around.
+>> ­— [[Jon]]
+>> 
+>> OK: issue exists with oldstable/Stretch, and is seemingly fixed in stable/Buster.
+>> `libcsv-text-xs-perl` doesn't seem to matter (presence or absence doesn't change
+>> the bug). Upgrading just `libtext-csv-perl` on a Stretch host with Buster's
+>> 1.99-1 is not sufficent to fix it. As per the error, I think libperl5 might be
+>> relevant, i.e. bug present in 5.24.1-3+deb9u5 and fixed by 5.28.1-6.
+>>
+>> EDIT: yes indeed merely upgrading to libperl5.28=5.28.1-6 in stretch fixes the
+>> issue.
+>> — [[Jon]]
+>>
+>> Post Buster-upgrade, and it's *still* broken on my webhost, which shows
+>> `[\[!table Error: Wide character at /usr/lib/x86_64-linux-gnu/perl/5.28/Encode.pm line 296.]]`
+>> with libperl5.28:amd64	5.28.1-6, libtext-csv-perl	1.99-1 and 
+>> libtext-csv-xs-perl	1.38-1. Further fiddling will commence.
+>> (removing libtext-csv-xs-perl does not help.)
+— [[Jon]]