X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/74baaeba00c90cd7a027e40e2f6d65695341a0e1..6d04c77cbfed893577105a3e6dc1d610d5950722:/doc/bugs/Monotone_rcs_support.mdwn

diff --git a/doc/bugs/Monotone_rcs_support.mdwn b/doc/bugs/Monotone_rcs_support.mdwn
index 11f93f11b..9e20f0a7e 100644
--- a/doc/bugs/Monotone_rcs_support.mdwn
+++ b/doc/bugs/Monotone_rcs_support.mdwn
@@ -18,7 +18,7 @@ Note: This patch requires a rather recent Monotone perl module (18 August 2007 o
 
 >>> Fair enough. Didn't realize you were a monotone committer. :-)
 
->>>> I am, but still a little newish.  Feedback is good.
+>>>> I am, but still a little newish.  Feedback is good.  In particular, this is my first major bit of PERL.
 
 > Having rcs_commit return a warning message when there's an unresolved conflict
 > isn't right; that message will populate the page edit box. You might want
@@ -33,11 +33,32 @@ Note: This patch requires a rather recent Monotone perl module (18 August 2007 o
 [[tag patch]]
 
 >> I've [[accepted|done]] this patch, thank you! 
->> 
+
+>>> Thanks for committing it.  I hate keeping my own diffs. :)
+
 >> I did make a few changes. Please review, and make sure it still works
 >> (a test case like we have for some of the other RCSes would be nice..)
->> 
+
+>>> Tested.  It still works at least as well as it did.  I'll try to get to a test case soon.
+>>> In checking the source I noticed a few bogus comments I left in when editing,
+>>> and a bug in page adding.
+>>> Here is a small patch for them:
+
+>>>> applied
+
 >> BTW, will all the monotone output parsing work if LANG != C?
->> 
+
+>>> It should (he says crossing fingers).
+>>> In the places where I do any complex parsing I'm using a special
+>>> version of the mtn commands designed for scripting.  They have a
+>>> stable, easy to parse, output that doesn't get translated (I think).
+
 >> Do monotone post-commit hooks actually use REV?
->> --[[Joey]]
+
+>>> Monotone post-commit hooks are written in Lua and can do
+>>> what they please.  Setting the REV environment var before
+>>> calling Ikiwiki seems reasonable, but I've not written the
+>>> Lua hook.
+
+>>>> So the rcs_notify support is not just untested, but can't work
+>>>> at all w/o further development.