X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/701ecfc2bb339d438d1138233e8a9250e580adf1..c3198e519388044894515565ee27f11614287bd1:/doc/todo/support_linking_to_cgit.mdwn

diff --git a/doc/todo/support_linking_to_cgit.mdwn b/doc/todo/support_linking_to_cgit.mdwn
index 5c61ff42f..ae7d23ce9 100644
--- a/doc/todo/support_linking_to_cgit.mdwn
+++ b/doc/todo/support_linking_to_cgit.mdwn
@@ -19,14 +19,27 @@ the substitution of `\[[file]]` in `diffurl` and `historyurl`?
 
 >> Thanks a lot! I've not looked at it yet, but will try to do so
 >> soonish, as this bug is a real problem for Tails when welcoming potential
->> new contributors.
->> 
->> Also, note that this does not affect recentchanges only:  we have
->> the same problem for URLs generated by the shortcut plugin, e.g.
->> `\[[!tails_gitweb config/chroot_local-includes/usr/local/sbin/unsafe-browser]]`
->> in a page (with the shortcut defined as
->> `\[[!shortcut name=tails_gitweb url="https://git-tails.immerda.ch/tails/plain/%s"]]`)
->> produces URLs with `/` encoded as `%2F`, which fails the same way
->> in combination with cgit. --[[intrigeri]]
+>> new contributors. --[[intrigeri]]
+
+>>> My `fix_diffurl_vs._cgit` branch now implements schmonz' change
+>>> for the Git plugin. Please review and merge if you like
+>>> it. --[[intrigeri]]
+
+>>>> Ping? --[[intrigeri]]
+
+>>>> Normally, my tendency towards pedantic preservation of existing APIs
+>>>> would make me implement a new token \[[file_less_escaped]] or
+>>>> something, analogous to `%s` vs. `%S` in [[shortcuts]]; but
+>>>> gitweb and cgit are both OK with `/` not being escaped, whereas
+>>>> only gitweb allows it to be escaped as `%2F`, so I think your
+>>>> solution is fine. Also, it would need a much better name than
+>>>> \[[file_less_escaped]], and I can't think of one.
+>>>>
+>>>> I don't have commit access to ikiwiki.info, but if I did,
+>>>> [[I'd merge this|/users/smcv/ready]]. --[[smcv]]
+
+>>>>> [[merged|done]] --[[Joey]]
 
 [[wishlist]]
+
+[[!tag patch]]