X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/6535c61746ba6946284be674f666c99ae8af82f0..fa620b1ecaee90b44de31a6f73ee2767e1afadac:/doc/bugs/unicode_encoded_urls_and_recentchanges.mdwn?ds=sidebyside diff --git a/doc/bugs/unicode_encoded_urls_and_recentchanges.mdwn b/doc/bugs/unicode_encoded_urls_and_recentchanges.mdwn index 2568aef38..88dbfc39b 100644 --- a/doc/bugs/unicode_encoded_urls_and_recentchanges.mdwn +++ b/doc/bugs/unicode_encoded_urls_and_recentchanges.mdwn @@ -11,3 +11,28 @@ the problem can be shown with an auto-setup'd ikiwiki without cgi when manually > Encoding issue, I figured out a fix. [[done]] --[[Joey]] +>> the link text works now, but the link goes to +>> `ikiwiki.cgi?page=uml%C3%A4ute&do=recentchanges_link`, which fails with +>> "missing page". it seems that bestlink can't handle utf8 encoded texts. (the +>> same happens, by the way, when using meta-redir to a page with high bytes in +>> the name.) +>> +>>> The problem is that all cgi inputs have to be explicitly decoded to +>>> utf-8, which I've now done for `recentchange_link`. +>>>> thanks a lot, i think that closed the bug. +>>> +>>> I cannot, however, reproduce a problem with meta redir. Here it +>>> generated the following html, which redirected the browser ok: +>>> +>>>> sorry, my fault -- it was the blank which needed to be replaced by an +>>>> underscore, not the high byte character +>> +>> update: i've had a look at the git options; you could run git with '-z' (NUL +>> termination) in the `git_commit_info` function; this would require some +>> changes in `parse_diff_tree`, but otherwise completely eliminate the +>> problems with git escaping. +>> +>>> If you would like to develop a patch to that effect, I'd be glad to +>>> drop the current nasty code. +>>>> i'll have a look, but i'm afraid that's above my current perl skills. +>>>> --[[chrysn]]