X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/64295da8aff69aec7bf7fd4df6225e67c894635e..82197bd0eaa216b841caace38c976acc7f6ad3fa:/doc/todo/else_parameter_for_map_plugin.mdwn?ds=inline diff --git a/doc/todo/else_parameter_for_map_plugin.mdwn b/doc/todo/else_parameter_for_map_plugin.mdwn index 859b027e7..981e50d43 100644 --- a/doc/todo/else_parameter_for_map_plugin.mdwn +++ b/doc/todo/else_parameter_for_map_plugin.mdwn @@ -1,4 +1,4 @@ -[[!tag patch]] +[[!tag patch done]] [[plugins/map]] (and I) could benefit from a bonus parameter: @@ -14,14 +14,14 @@ documentation yet, I'm waiting for feedback first, but I'll do it for sure. -- [ >> Hmmm, what do you mean? Adding a syntax such as the one below? >> Or something else? - \[[if test="map(" then="..." else="..."]] + \[[!if test="map(" then="..." else="..."]] >> What would you write in the `then` clause? >> I'm not opposed at all to rewrite my two-liner, but I don't understand. >> --[[intrigeri]] - \[[if test="foo/*" then=""" - [[map pages="foo/*"]] + \[[!if test="foo/*" then=""" + [[!map pages="foo/*"]] """ else="no pages"]] --[[Joey]] @@ -35,3 +35,22 @@ documentation yet, I'm waiting for feedback first, but I'll do it for sure. -- [ >>> heavy duplicated syntax without bloating the map plugin with features >>> no-one but me needs. On the other other hand, the patch is a 3-liner. >>> I'm not fixed yet, I'll think about it. --[[intrigeri]] + +>>>> Write a [[plugins/template]] which accepts a pagespec and an +>>>> "else" clause, and then you won't have to duplicate the +>>>> pagespec. --[[JoshTriplett]] + +>>>> Yeah, the patch is obviously very simple. My problem with it really is +>>>> that there would seem to be several other places in ikiwiki where +>>>> someone might want to be able to handle an "else" case where a +>>>> pagespec expands to nothing. And adding else cases for all of them +>>>> could be a bit much. --[[Joey]] + +>>>>> Agreed, and tagging as done. For the record, here is the [[plugins/template]] I use: + + \[[!if test="" + then=""" + [[!map pages=""]]""" + else=""]] + +>>>>> --[[intrigeri]]