X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/5b381e7fd157c0e381a87b386996485d6c7067c8..b5a05dbc33a1a24a6a20701d2756a2d4f4a77995:/doc/todo/admonitions.mdwn

diff --git a/doc/todo/admonitions.mdwn b/doc/todo/admonitions.mdwn
index c68ce11f8..16f0b00ee 100644
--- a/doc/todo/admonitions.mdwn
+++ b/doc/todo/admonitions.mdwn
@@ -149,3 +149,22 @@ in either case (which will at least mean there'll be another avenue for people t
 >>> was a much earlier commit than `d0099568`, so "Compare" would include all the unrelated upstream changes. If instead either `master` was `d0099568`, or
 >>> `admonitions` was rebased on top of whatever your `master` was, then GitLab's "Compare" would be useful. As it is, I cloned locally and did the necessary
 >>> `git` incantation. *— [[Jon]], 2020-08-12*
+
+>>>> I have rebased all my current branches onto `debian/3.20190228-1` because that's what I'm patching in production, and I have updated my `master` branch on GitLab to follow that. The branches are admonitions, [bootstrap-plugin](https://ikiwiki.info/plugins/contrib/bootstrap), [toc-skip](https://ikiwiki.info/todo/allow_toc_to_skip_entries), [page-template-variable](https://ikiwiki.info/todo/include_page_variable_in_base_templates), [js-newline](https://ikiwiki.info/bugs/javascript_resources_placed_after_html_tag/), [i18n-headinganchors](https://ikiwiki.info/plugins/contrib/i18nheadinganchors), [dev/git-annex-support](https://ikiwiki.info/todo/git-annex_support/), and [geo-scheme](https://ikiwiki.info/todo/add_geo_uri_scheme/). Phew. Is that what you needed? It's still kind of a mess, but it should make it easier for you to review... --[[anarcat]]
+
+----
+
+I've finally started playing around with this plugin. I think the default CSS needs
+tweaking. I see "warning" has `padding` to try to account for the icon size, but 
+the other admonitions do not. Perhaps they need to inherit some style from a common
+class? Either way, the padding does not seem to work. This is a fresh ikiwiki with
+the actiontab theme enabled:
+
+<img src=https://jmtd.net/tmp/admonition.png alt="pic demoing admonitions" />
+*— [[Jon]], 2021-02-15*
+
+> I had kind of given up on this guy here, to be honest, but if you want to see a working version, you can look at [my sandbox](https://anarc.at/sandbox/). Obviously, the CSS does need more tweaking, but it seems it's not my specialty. ;) -- [[anarcat]]
+
+>> It turned out to be a simple fix, a missing semicolon. [patch here](https://github.com/jmtd/ikiwiki/commit/3e31200ed258ba1f7ab1652d6bc2d035a9e5c990). The rest of that branch is just your admonitions branch rebased onto `3.20200202.3`. *—[[Jon]], 2021-02-18*
+
+>>> Interesting. That was of course, a missing semicolon, not sure how I missed that. I cherry-picked your patch, but I wonder why I wasn't seeing the problem on my end... Maybe I had other padding that was covering for this... Thanks, in any case! :) -- [[anarcat]]