X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/5a734d59115a38312ff739baacbc528dcfebba28..7bdb9846379c5f410662c0a84785e52152a4d434:/doc/patchqueue/various_fixes.mdwn?ds=sidebyside diff --git a/doc/patchqueue/various_fixes.mdwn b/doc/patchqueue/various_fixes.mdwn index 81cb6c592..318e7e941 100644 --- a/doc/patchqueue/various_fixes.mdwn +++ b/doc/patchqueue/various_fixes.mdwn @@ -81,28 +81,11 @@ much help I'm afraid. >> to adjust permissions on my cgi-dir. This seems to be the root of the >> problem. ----- - - --- IkiWiki/Plugin/search.pm - +++ IkiWiki/Plugin/search.pm - @@ -99,7 +99,7 @@ - close TEMPLATE; - $cgi="$estdir/".IkiWiki::basename($config{cgiurl}); - unlink($cgi); - - symlink("/usr/lib/estraier/estseek.cgi", $cgi) || - + symlink("/usr/local/libexec/estseek.cgi", $cgi) || - error("symlink $cgi: $!"); - } # }}} - -obviously I'm not asking you to include this patch, but it would -be good if this sort of thing was configurable (at build time?). I can -have a go if you like, but I'm not sure what would be acceptable to -you. +>>> Ah, I think it's better to keep the permissions of the repository +>>> and source directory sane (755) and make the cgi suid to your user, +>>> which is how it's designed to work. -> This should be made configurable via an option in %IkiWiki::config, -> the search plugin could register a getopt hook to handle it. --[[Joey]] - ->> Like this? +>>>> I realise that now, and I now have a much more sane setup that works. ---- @@ -178,29 +161,12 @@ informative if that code path is ever taken, but I hope that it never is. >> >> is what pointed me to find the problem/workaround. - - ----- - -As for backports there is a problem with the sarge version of libcgi-session-perl -and my sslcookie patch (complaints about a missing include file auto/CGI/Session/cookie.al IIRC). -This file does not and has not ever existed, but it appears to be fixed in -the backport of libcgi-session-perl that I did. That puts the dependency -required at somewhere between 3.95-2 and 4.14-1. This could then be added -to debian/control. It would mean one more package to backport, but stops the -bug if anyone actually uses my sslcookie option except me. - -> May as well, done --[[Joey]] - ->> Thanks. - -As for backports I managed with - - * ikiwiki_1.26 - * libcgi-formbuilder-perl_3.03.01-1 - * libcgi-session-perl_4.14-1 - -backported to sarge, with bpo in sources.list. This only covers Depends: though, -for instance hyperestraier needs to be backported, which I haven't got -round to yet as there is a chain to do. +>>> Given that verification, an untaint contingent on the value of $^V +>>> sounds reasonable and I'd accept such a patch. I'm not quite sure which +>>> version(s) of perl it should check for. +>>>> I'm not going to write one though. I don't know what versions either, +>>>> but I think the evil of the special case is too much in this case. If +>>>> you are happy to insist on a newer version of perl then I will leave +>>>> it at that and sort something out locally. If you want the patch I will +>>>> code it though, as I realise you may want to support sarge installs.