X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/57f2d6fa3136f1a599612832f7aeba6370bf3758..486076c94367a40ff6a5e2476d98b87cd8d64f96:/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn diff --git a/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn index f000878b7..8b1dd74a7 100644 --- a/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn +++ b/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn @@ -2,6 +2,16 @@ As [[Add instructive commit messages for add _47_ edit pages]], but for `remove. I use a `join()` since it at least looks like the plugin is able to remove several pages at once (`foreach` looping over file parameters), thus holding multiple entries in `@pages`. I haven't seen this happen, though. +> I feel that anything that shows a change should show what files were +> changed (at least as an easily accessible option), so mentioning +> filenames in commits is almost always clutter. +> +> It could be argued that there should be no message at all here, unless +> the user provides one (which they currently cannot), as is done when +> adding files. But the entire removal of a page from a wiki is a fairly +> unusual circumstance that is probably best highlighted as such in +> recentchanges. --[[Joey]] + Diff follows. --[[Daniel Andersson]] [[!tag patch]]