X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/5351cdd0f0b1475775d09b342e244f79626d7acd..ab4f499c8d903b3e66655b42202a29ece975112b:/doc/todo/support_linking_to_cgit.mdwn diff --git a/doc/todo/support_linking_to_cgit.mdwn b/doc/todo/support_linking_to_cgit.mdwn index 758fd0bf4..ab6172ad1 100644 --- a/doc/todo/support_linking_to_cgit.mdwn +++ b/doc/todo/support_linking_to_cgit.mdwn @@ -21,4 +21,25 @@ the substitution of `\[[file]]` in `diffurl` and `historyurl`? >> soonish, as this bug is a real problem for Tails when welcoming potential >> new contributors. --[[intrigeri]] +>>> My `fix_diffurl_vs._cgit` branch now implements schmonz' change +>>> for the Git plugin. Please review and merge if you like +>>> it. --[[intrigeri]] + +>>>> Ping? --[[intrigeri]] + +>>>> Normally, my tendency towards pedantic preservation of existing APIs +>>>> would make me implement a new token \[[file_less_escaped]] or +>>>> something, analogous to `%s` vs. `%S` in [[shortcuts]]; but +>>>> gitweb and cgit are both OK with `/` not being escaped, whereas +>>>> only gitweb allows it to be escaped as `%2F`, so I think your +>>>> solution is fine. Also, it would need a much better name than +>>>> \[[file_less_escaped]], and I can't think of one. +>>>> +>>>> I don't have commit access to ikiwiki.info, but if I did, +>>>> [[I'd merge this|/users/smcv/yesplease]]. --[[smcv]] + +>>>>> [[merged|done]] --[[Joey]] + [[wishlist]] + +[[!tag patch]]