X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/4f6728a68536f5ea70d3e7b45e56bac099f7ed4f..a42de69fbb3e775dd407d24bf90534a07219710a:/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn diff --git a/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn b/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn index 302d7b605..eb95e9992 100644 --- a/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn +++ b/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn @@ -1,17 +1,22 @@ -The final `` in [`recentchanges.tmpl`][tmpl] gets wrapped in a +The final `` in `recentchanges.tmpl` gets wrapped in a `
` tag for some reason, resulting in the following invalid XHTML at the end of the [[RecentChanges]] page
+> I'll bet this is fixed if you use the markdown 1.2 prerelease, which has +> a much less buggy html parser. (Ah, I see below that was the case.) +> --[[Joey]] + Also, there is a problem with the `` tag in the inline diff output. `` tags is not allowed within a `
` block. Maybe the smiley plugin should be disabled on [[RecentChanges]]? +> See [[Smileys_in_the_block_code]], which is now fixed. --[[Joey]] + See the [validator output][validate] for more details. - [tmpl]: http://git.ikiwiki.info/?p=ikiwiki;a=blob_plain;f=templates/recentchanges.tmpl;hb=HEAD [validate]: http://validator.w3.org/check?uri=http://ikiwiki.info/recentchanges/ - - - @@ -31,22 +36,20 @@ processing and throw an error. —[Jason Blevins](http://jblevins.org/) Here is a simple patch for the refresh problem. I haven't figured out what's causing the recentchanges bug yet. +--[[JasonBlevins]] - diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm - index 8a9a538..0afe1c3 100644 - --- a/IkiWiki/Plugin/meta.pm - +++ b/IkiWiki/Plugin/meta.pm - @@ -186,7 +186,7 @@ sub preprocess (@) { #{{{ - $value=encode_entities($value); - } - my $delay=int(exists $params{delay} ? $params{delay} : 0); - - my $redir=""; - + my $redir=""; - if (! $safe) { - $redir=scrub($redir); - } +> Thanks, applied that patch. --[[Joey]] +- - - ---[[JasonBlevins]] +It turns out that the invalid XHTML on the recent changes page is due to +a bug in Markdown. I was using the packaged version of markdown in +Ubuntu (Gutsy and markdown 1.0.1-6). Everything is fine +after installing the most recent version of Text::Markdown from CPAN. + +Note that the above patch for the redirect tag is still applicable and +the smiley issue remains open. --[[JasonBlevins]] + +> This bug is [[done]], all issues are fixed. --[[Joey]] -[[tag patch]] +[[!tag patch]]