X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/3f07701cd9023d7f0325de0aacf50bb583654b52..2e3e266aa7c88a5a8ce7d60b10f2d306af6bdd36:/doc/todo/calendar_autocreate.mdwn diff --git a/doc/todo/calendar_autocreate.mdwn b/doc/todo/calendar_autocreate.mdwn index b350dcdec..02659d0d1 100644 --- a/doc/todo/calendar_autocreate.mdwn +++ b/doc/todo/calendar_autocreate.mdwn @@ -34,7 +34,8 @@ won't be offended if you correct stuff you consider awkward): > > > `tag_autocreate_commit` exists because when tag autocreation > > > was introduced, they were always in the `$srcdir` and committed. > > > I changed it so that it was possible to put them in the [[plugins/transient]] -> > > underlay and not commit them. +> > > underlay and not commit them. It defaults to 1 to preserve existing +> > > functionality. > > > > > > When automatic tag pages (or autoindex pages) are not committed, they > > > go in the transient underlay, which means they can't cause conflicts: @@ -42,6 +43,11 @@ won't be offended if you correct stuff you consider awkward): > > > `$srcdir` hides a page of the same name in an underlay). I thought > > > this implementation did the same when not committing? --[[smcv]] > +> > > > I did not realize how easy it was to use the [[plugins/transient]] +> > > > plugin! I [[took it into +> > > > account|https://github.com/paternal/ikiwiki/commit/492a22ac75f8b41a427a98c44525b01a6fd181b5]]. +> > > > -- [[Louis|spalax]] +> > I'd personally do the conditional in gencalendaryear more like: > > [[!format perl """ @@ -171,3 +177,7 @@ sub gencalendaryear { > --[[smcv]] > > > Thank you for this review. -- [[Louis|spalax]] + +--- + +[[smcv]], can you please go on reviewing this?