X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/33e9442f4ae174ddf58b61b04190a26d5ac0ccce..652beaf48c64d5dd10cb0e0702f1fb284c96177a:/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn?ds=inline diff --git a/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn b/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn index 1f519ddca..a1b38257a 100644 --- a/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn +++ b/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn @@ -8,6 +8,21 @@ should be written as `my @buttons=(gettext("Save Page"), gettext("Preview"), gettext("Cancel"));` +> Yes, these need to be fixed. But note that the localised texts come back +> into ikiwiki and are used in various places, including plugins. +> Including, possibly, third-party plugins. So localising the buttons would +> seem to require converting from the translations back into the C locale +> when the form is posted. --[[Joey]] + +>> Wouldn't it be more easy to change all calls to the corrects ones (including in plugins) ? +>> For instance in the same file (CGI.pm): `elsif ($form->submitted eq gettext("Save Page")) {`. +>> That way no conversion to the C locale is needed. +>> gettext use should just be publicized in documentation (at least in [[plugins/write]]). --[[bbb]] + +>>> It would be easy, but it could break third-party plugins that hardcode +>>> the english strings. It's also probably less efficient to run gettext +>>> over and over. --[[Joey]] + In standards templates things seems wrongly written too. For instance in page.tmpl line like: `