X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/324ee23b9bde305c6a68d4a34bde7335949583c7..dab50d3b7c91c0ef444c4fc31879117e4824c406:/doc/todo/pagespec_aliases.mdwn diff --git a/doc/todo/pagespec_aliases.mdwn b/doc/todo/pagespec_aliases.mdwn index bd64a5040..54e252956 100644 --- a/doc/todo/pagespec_aliases.mdwn +++ b/doc/todo/pagespec_aliases.mdwn @@ -211,3 +211,33 @@ or [[smcv]]?) or otherwise feed back on this? Thanks! — [[Jon]] (2018-09-25) > this works.) > > --[[smcv]] + +---- + +Thank you for the review (nearly a year ago, I've just noticed!). I've +added checks for the issues you outline above, and test coverage for all +those issues. +I've also decided to rename the plugin (back) to just "alias": +I mooted that right back when I started this but I was worried about +potential ambiguity. That was ten years ago and I think the concern has +prove unfounded. I've left the config key as `pagespec_aliases` though, +as that's one area I think its clearer. + +With regards `aliasname()` versus `alias(aliasname)`: +I've given this some thought. Pros and cons of that approach: it would be +a little uglier; you would not inadvertently clash with a PageSpec defined +elsewhere. However, I wonder if someone might actually *want* to define a +PageSpec this way that was the same as that defined by something else: Perhaps, +you have disabled a plugin that defined a PageSpec name and you want to substitute +what it would have expanded to with something else, for example. + +I will (after writing this) rebase my branch. Please take another look! +(just in case the rebase and/or the "-" in the branchnames causes problems +with IkiWiki's auto-mirror-pull, the branch is here: +) + +*— [[Jon]], 2021-01-10* + +> Scratch that, more work needed ☹ *— [[Jon]], 2021-01-11* + +>> This is really ready now. *— [[Jon]], 2021-01-13*