X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/1f54c13ec24977988a303f004f3fc08ee2e01abc..33cade908232d636c623108b318f5b256fefceb1:/doc/plugins/po.mdwn?ds=sidebyside diff --git a/doc/plugins/po.mdwn b/doc/plugins/po.mdwn index 0a8a77a3c..923ccd63a 100644 --- a/doc/plugins/po.mdwn +++ b/doc/plugins/po.mdwn @@ -215,16 +215,6 @@ TODO Security checks --------------- -- `refreshpofiles` uses `system()`, whose args have to be checked more - thoroughly to prevent any security issue (command injection, etc.). - > Always pass `system()` a list of parameters to avoid the shell. - > I've checked in a change fixing that. --[[Joey]] -- `refreshpofiles` and `refreshpot` create new files; this may need - some checks, e.g. using `IkiWiki::prep_writefile()` - > Yes, it would be ideal to call `prep_writefile` on each file - > that they write, beforehand. This way you'd avoid symlink attacks etc to the - > generated po/pot files. I haven't done it, but it seems pretty trivial. - > --[[Joey]] - Can any sort of directives be put in po files that will cause mischief (ie, include other files, run commands, crash gettext, whatever). @@ -255,18 +245,6 @@ does. This is actually a duplicate for [[bugs/pagetitle_function_does_not_respect_meta_titles]], which might be fixed by something like [[todo/using_meta_titles_for_parentlinks]]. -### websetup - -Which configuration settings are safe enough for websetup? - -> I see no problems with `po_master_language` and `po_slave_languages` -> (assuming websetup handles the hashes correctly). Would not hurt to check -> that the values of these are legal language codes, in `checkconfig`. -> `po_translatable_pages` seems entirely safe. `po_link_to` w/o usedirs -> causes ikiwiki to error out. If it were changed to fall back to a safe -> setting in this case rather than error, it would be safe. -> --[[Joey]] - ### backlinks `po_link_to = negotiated`: if a given translatable `sourcepage.mdwn` @@ -276,10 +254,10 @@ in the backlinks. `po_link_to = current`: seems to work nicely -### license +### parentlinks -> Could you please put a copyright and license on po.pm? I assume it's -> GPLed as it's based on po4a-translate. --[[Joey]] +When `usedirs` is disabled and the home page is translatable, the +parent link to the wiki home page is broken (`/index.html`). Translation quality assurance -----------------------------