X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/17b2afe721d5b8fd2468fca56e91fe83bf49be64..9480dc44277ad9301f1e1eba5b09990b459e7b26:/IkiWiki/Plugin/sparkline.pm?ds=sidebyside

diff --git a/IkiWiki/Plugin/sparkline.pm b/IkiWiki/Plugin/sparkline.pm
index 1ed65e5b7..42665ac63 100644
--- a/IkiWiki/Plugin/sparkline.pm
+++ b/IkiWiki/Plugin/sparkline.pm
@@ -24,6 +24,7 @@ sub getsetup () {
 		plugin => {
 			safe => 1,
 			rebuild => undef,
+			section => "widget",
 		},
 }
 
@@ -75,7 +76,7 @@ sub preprocess (@) {
 			my ($x, $y, $color, $diameter, $text, $location)=
 				split(/\s*,\s*/, $value);
 			if (! defined $diameter || $diameter < 0) {
-				error gettext("bad featurepoint diameter");
+				error gettext("invalid featurepoint diameter");
 			}
 			$x=int($x);
 			$y=int($y);
@@ -85,7 +86,7 @@ sub preprocess (@) {
 			if (defined $location) {
 				$location=$locmap{$location};
 				if (! defined $location) {
-					error gettext("bad featurepoint location");
+					error gettext("invalid featurepoint location");
 				}
 			}
 			$php.=qq{\$sparkline->SetFeaturePoint($x, $y, '$color', $diameter};
@@ -101,7 +102,7 @@ sub preprocess (@) {
 
 	my $height=int($params{height} || 20);
 	if ($height < 2 || $height > 100) {
-		error gettext("bad height value");
+		error gettext("invalid height value");
 	}
 	if ($style eq "Bar") {
 		$php.=qq{\$sparkline->Render($height);\n};
@@ -112,7 +113,7 @@ sub preprocess (@) {
 		}
 		my $width=int($params{width});
 		if ($width < 2 || $width > 1024) {
-			error gettext("bad width value");
+			error gettext("invalid width value");
 		}
 		$php.=qq{\$sparkline->RenderResampled($width, $height);\n};
 	}
@@ -130,7 +131,7 @@ sub preprocess (@) {
 
 	if (! -e "$config{destdir}/$fn") {
 		my $pid;
-		my $sigpipe=0;;
+		my $sigpipe=0;
 		$SIG{PIPE}=sub { $sigpipe=1 };
 		$pid=open2(*IN, *OUT, "php");
 
@@ -149,7 +150,7 @@ sub preprocess (@) {
 
 		waitpid $pid, 0;
 		$SIG{PIPE}="DEFAULT";
-		if ($sigpipe) {
+		if ($sigpipe || ! defined $png) {
 			error gettext("failed to run php");
 		}