X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/16fd84326915d235c1509e03606d91bd08e7f277..3bb00d142a4d31316fc6f0eb1277aa2fafe4dbe9:/doc/plugins/map/discussion.mdwn diff --git a/doc/plugins/map/discussion.mdwn b/doc/plugins/map/discussion.mdwn index 9fdd32eeb..2f7b140d6 100644 --- a/doc/plugins/map/discussion.mdwn +++ b/doc/plugins/map/discussion.mdwn @@ -16,5 +16,34 @@ Thoughts, anyone? --[[KarlMW]] We'd also very much like to have an option to display the title of the page instead of the filename in the map plugin. --Andrew -There's a patch implementing this in [[debbug 484510]]. It needs a few fixes -before I merge it. --[[Joey]] +There's a patch implementing this in [[!debbug 484510]]. It needs a few fixes +before I merge it. Now applied. --[[Joey]] + +---- + +I noticed that when the pagespec returns no map items, the map plugin does not close off the ul and div tags. Below is a simple patch +that seems to work on the examples I tried. I am a beginner so please help me out here. Thanks. --[[harishcm]] + + --- a/map.pm + +++ b/map.pm + @@ -81,6 +81,13 @@ + my $openli=0; + my $addparent=""; + my $map = "
\n\n
\n"; + + return $map; + + } + + + foreach my $item (sort keys %mapitems) { + my @linktext = (length $mapitems{$item} ? (linktext => $mapitems{$item}) : ()); + $item=~s/^\Q$common_prefix\E\/// + +> This was also reported as [[bugs/map_fails_to_close_ul_element_for_empty_list]]; +> this patch is simpler than the one there, but has the same problem (it emits +> ``, which technically isn't valid HTML either). --[[smcv]] + +>> Thanks for the tip, I added another patch addressing the issue at +>> [[bugs/map_fails_to_close_ul_element_for_empty_list]]. --[[harishcm]]