X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/1202b4fd7b305b223d64f9e9f24424b72c81ab6d..ceae681a438a044778df212642d5f174d8bbc182:/IkiWiki/CGI.pm?ds=sidebyside
diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index 8d86d8d3e..07319ad22 100644
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -137,7 +137,7 @@ sub cgi_signin ($$) { #{{{
error($@) if $@;
my $form = CGI::FormBuilder->new(
title => "signin",
- header => 1,
+ name => "signin",
charset => "utf-8",
method => 'POST',
required => 'NONE',
@@ -145,7 +145,7 @@ sub cgi_signin ($$) { #{{{
params => $q,
action => $config{cgiurl},
header => 0,
- template => scalar template_params("signin.tmpl"),
+ template => {type => 'div'},
stylesheet => baseurl()."style.css",
);
my $buttons=["Login"];
@@ -206,6 +206,7 @@ sub cgi_prefs ($$) { #{{{
error($@) if $@;
my $form = CGI::FormBuilder->new(
title => "preferences",
+ name => "preferences",
header => 0,
charset => "utf-8",
method => 'POST',
@@ -216,8 +217,13 @@ sub cgi_prefs ($$) { #{{{
javascript => 0,
params => $q,
action => $config{cgiurl},
- template => scalar template_params("prefs.tmpl"),
+ template => {type => 'div'},
stylesheet => baseurl()."style.css",
+ fieldsets => [
+ [login => gettext("Login")],
+ [preferences => gettext("Preferences")],
+ [admin => gettext("Admin")]
+ ],
);
my $buttons=["Save Preferences", "Logout", "Cancel"];
@@ -226,10 +232,12 @@ sub cgi_prefs ($$) { #{{{
});
$form->field(name => "do", type => "hidden");
- $form->field(name => "email", size => 50);
+ $form->field(name => "email", size => 50, fieldset => "preferences");
$form->field(name => "subscriptions", size => 50,
+ fieldset => "preferences",
comment => "(".htmllink("", "", "PageSpec", noimageinline => 1).")");
- $form->field(name => "banned_users", size => 50);
+ $form->field(name => "banned_users", size => 50,
+ fieldset => "admin");
my $user_name=$session->param("name");
if (! is_admin($user_name)) {
@@ -290,15 +298,13 @@ sub cgi_editpage ($$) { #{{{
my $q=shift;
my $session=shift;
- my @fields=qw(do rcsinfo subpage from page type editcontent comments
- newfile);
+ my @fields=qw(do rcsinfo subpage from page type editcontent comments);
my @buttons=("Save Page", "Preview", "Cancel");
eval q{use CGI::FormBuilder};
error($@) if $@;
my $form = CGI::FormBuilder->new(
fields => \@fields,
- header => 1,
charset => "utf-8",
method => 'POST',
validate => {
@@ -308,8 +314,10 @@ sub cgi_editpage ($$) { #{{{
javascript => 0,
params => $q,
action => $config{cgiurl},
+ header => 0,
table => 0,
template => scalar template_params("editpage.tmpl"),
+ wikiname => $config{wikiname},
);
run_hooks(formbuilder_setup => sub {
@@ -333,12 +341,16 @@ sub cgi_editpage ($$) { #{{{
my $file;
my $type;
- if (exists $pagesources{$page}) {
+ if (exists $pagesources{$page} && $form->field("do") ne "create") {
$file=$pagesources{$page};
$type=pagetype($file);
if (! defined $type) {
error(sprintf(gettext("%s is not an editable page"), $page));
}
+ if (! $form->submitted) {
+ $form->field(name => "rcsinfo",
+ value => rcs_prepedit($file), force => 1);
+ }
}
else {
$type=$form->param('type');
@@ -351,37 +363,31 @@ sub cgi_editpage ($$) { #{{{
}
$type=$config{default_pageext} unless defined $type;
$file=$page.".".$type;
+ if (! $form->submitted) {
+ $form->field(name => "rcsinfo", value => "", force => 1);
+ }
}
-
$form->field(name => "do", type => 'hidden');
$form->field(name => "from", type => 'hidden');
$form->field(name => "rcsinfo", type => 'hidden');
$form->field(name => "subpage", type => 'hidden');
- $form->field(name => "page", value => $page, force => 1);
+ $form->field(name => "page", value => pagetitle($page, 1), force => 1);
$form->field(name => "type", value => $type, force => 1);
$form->field(name => "comments", type => "text", size => 80);
$form->field(name => "editcontent", type => "textarea", rows => 20,
cols => 80);
- $form->field(name => "newfile", type => 'hidden');
$form->tmpl_param("can_commit", $config{rcs});
$form->tmpl_param("indexlink", indexlink());
$form->tmpl_param("helponformattinglink",
htmllink("", "", "HelpOnFormatting", noimageinline => 1));
$form->tmpl_param("baseurl", baseurl());
- if (! $form->submitted) {
- $form->field(name => "rcsinfo", value => rcs_prepedit($file),
- force => 1);
- $form->field(name => "newfile",
- value => ! -e "$config{srcdir}/$file",
- force => 1);
- }
if ($form->submitted eq "Cancel") {
- if ($form->field(name => "newfile") && defined $from) {
+ if ($form->field("do") eq "create" && defined $from) {
redirect($q, "$config{url}/".htmlpage($from));
}
- elsif ($form->field(name => "newfile")) {
+ elsif ($form->field("do") eq "create") {
redirect($q, $config{url});
}
else {
@@ -390,17 +396,11 @@ sub cgi_editpage ($$) { #{{{
return;
}
elsif ($form->submitted eq "Preview") {
- my $content=$form->field('editcontent');
- my $comments=$form->field('comments');
- $form->field(name => "editcontent",
- value => $content, force => 1);
- $form->field(name => "comments",
- value => $comments, force => 1);
$form->tmpl_param("page_preview",
htmlize($page, $type,
linkify($page, "",
preprocess($page, $page,
- filter($page, $content), 0, 1))));
+ filter($page, $page, $form->field('editcontent')), 0, 1))));
}
else {
$form->tmpl_param("page_preview", "");
@@ -466,11 +466,12 @@ sub cgi_editpage ($$) { #{{{
$form->tmpl_param("page_select", 1);
$form->field(name => "page", type => 'select',
- options => { map { $_ => pagetitle($_, 1) } @editable_locs },
- value => $best_loc);
+ options => [ map { pagetitle($_, 1) } @editable_locs ],
+ value => pagetitle($best_loc, 1));
$form->field(name => "type", type => 'select',
options => \@page_types);
$form->title(sprintf(gettext("creating %s"), pagetitle($page)));
+
}
elsif ($form->field("do") eq "edit") {
check_canedit($page, $q, $session);
@@ -490,19 +491,40 @@ sub cgi_editpage ($$) { #{{{
$form->title(sprintf(gettext("editing %s"), pagetitle($page)));
}
- print $form->render(submit => \@buttons);
+ printheader($session);
+ print misctemplate($form->title, $form->render(submit => \@buttons));
}
else {
# save page
check_canedit($page, $q, $session);
- if (! -e "$config{srcdir}/$file" && ! $form->field(name => 'newfile')){
+
+ my $exists=-e "$config{srcdir}/$file";
+
+ if ($form->field("do") ne "create" &&
+ ! $exists && ! -e "$config{underlaydir}/$file") {
$form->tmpl_param("page_gone", 1);
- $form->field(name => "newfile",
- value => 1, force => 1);
+ $form->field(name => "do", value => "create", force => 1);
+ $form->tmpl_param("page_select", 0);
+ $form->field(name => "page", type => 'hidden');
+ $form->field(name => "type", type => 'hidden');
+ $form->title(sprintf(gettext("editing %s"), $page));
+ printheader($session);
+ print misctemplate($form->title, $form->render(submit => \@buttons));
+ return;
+ }
+ elsif ($form->field("do") eq "create" && $exists) {
+ $form->tmpl_param("creation_conflict", 1);
+ $form->field(name => "do", value => "edit", force => 1);
$form->tmpl_param("page_select", 0);
$form->field(name => "page", type => 'hidden');
$form->field(name => "type", type => 'hidden');
- print $form->render(submit => \@buttons);
+ $form->title(sprintf(gettext("editing %s"), $page));
+ $form->field("editcontent",
+ value => readfile("$config{srcdir}/$file").
+ "\n\n\n".$form->field("editcontent"),
+ force => 1);
+ printheader($session);
+ print misctemplate($form->title, $form->render(submit => \@buttons));
return;
}
@@ -524,7 +546,8 @@ sub cgi_editpage ($$) { #{{{
$form->field(name => "page", type => 'hidden');
$form->field(name => "type", type => 'hidden');
$form->title(sprintf(gettext("editing %s"), $page));
- print $form->render(submit => \@buttons);
+ printheader($session);
+ print misctemplate($form->title, $form->render(submit => \@buttons));
return;
}
@@ -536,7 +559,7 @@ sub cgi_editpage ($$) { #{{{
$message=$form->field('comments');
}
- if ($form->field(name => "newfile")) {
+ if (! $exists) {
rcs_add($file);
}
@@ -568,7 +591,8 @@ sub cgi_editpage ($$) { #{{{
$form->field(name => "page", type => 'hidden');
$form->field(name => "type", type => 'hidden');
$form->title(sprintf(gettext("editing %s"), $page));
- print $form->render(submit => \@buttons);
+ printheader($session);
+ print misctemplate($form->title, $form->render(submit => \@buttons));
return;
}
else {
@@ -631,9 +655,6 @@ sub cgi (;$$) { #{{{
cgi_recentchanges($q);
return;
}
- elsif ($do eq 'hyperestraier') {
- cgi_hyperestraier();
- }
# Need to lock the wiki before getting a session.
lockwiki();
@@ -667,7 +688,10 @@ sub cgi (;$$) { #{{{
print gettext("You are banned.");
cgi_savesession($session);
}
- elsif ($do eq 'signin') {
+
+ run_hooks(sessioncgi => sub { shift->($q, $session) });
+
+ if ($do eq 'signin') {
cgi_signin($q, $session);
cgi_savesession($session);
}
@@ -680,21 +704,6 @@ sub cgi (;$$) { #{{{
elsif ($do eq 'create' || $do eq 'edit') {
cgi_editpage($q, $session);
}
- elsif ($do eq 'blog') {
- my $page=titlepage(decode_utf8($q->param('title')));
- $page=~s/(\/)/"__".ord($1)."__"/eg; # escape slashes too
- # if the page already exists, munge it to be unique
- my $from=$q->param('from');
- my $add="";
- while (exists $pagecase{lc "$from/$page$add"}) {
- $add=1 unless length $add;
- $add++;
- }
- $q->param('page', $page.$add);
- # now run same as create
- $q->param('do', 'create');
- cgi_editpage($q, $session);
- }
elsif ($do eq 'postsignin') {
error(gettext("login failed, perhaps you need to turn on cookies?"));
}