X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/0fc36d36be86a67fb99f1853632f845c98c95651..04c74a45983ad2368eaa1f8ab0afb2a16108ac19:/doc/todo/autoindex_should_use_add__95__autofile.mdwn diff --git a/doc/todo/autoindex_should_use_add__95__autofile.mdwn b/doc/todo/autoindex_should_use_add__95__autofile.mdwn index 0ac3c4225..f3fb24c16 100644 --- a/doc/todo/autoindex_should_use_add__95__autofile.mdwn +++ b/doc/todo/autoindex_should_use_add__95__autofile.mdwn @@ -1,9 +1,11 @@ `add_autofile` is a generic version of [[plugins/autoindex]]'s code, so the latter should probably use the former. --[[smcv]] +> [[merged|done]] --[[Joey]] + ---- -[[!template id=gitbranch branch=smcv/autoindex-autofile author="[[smcv]]"]] +[[!template id=gitbranch branch=smcv/ready/autoindex-autofile author="[[smcv]]"]] I'm having trouble fixing this: @@ -11,7 +13,11 @@ I'm having trouble fixing this: # the rest should perhaps be added to the autofile machinery By "a generic version of" above, it seems I mean "almost, but not -quite, entirely unlike". I tried digging through the git history for the +quite, entirely unlike". + +> As long as it's not Tea. ;) --[[Joey]] + +I tried digging through the git history for the reasoning behind the autofile and autoindex implementations, but now I'm mostly confused. @@ -60,6 +66,13 @@ I'm less sure that these shouldn't create the tag page: we deleted the manually-created version, but that doesn't necessarily mean we don't want *something* to exist. +> That could be argued, but it's a very DWIM thing. Probably best to keep +> the behavior simple and predictable, so one only needs to remember that +> when a page is deleted, nothing will ever re-create it behind ones back. +> --[[Joey]] + +>> Fair enough, I'll make autoindex do that. --s + ## autoindex The autoindex machinery records a more complex set. Items are added to the @@ -87,12 +100,21 @@ However, unlike the generic autofile infrastructure, `autoindex` forgets that it shouldn't re-create the deleted page in the latter two situations: * create auto-del-create-del/child, resulting in auto-del-create-del being - created automatically + created automatically * delete auto-del-create-del; it's added to `%deleted` and not re-created * create auto-del-create-del manually; it's removed from `%deleted` * delete auto-del-create-del again (it's re-created) +and + * create create-del-auto * delete create-del-auto; it's not added to `%deleted` because there's no - child that would cause it to exist + child that would cause it to exist * create create-del-auto/child + +> I doubt there is any good reason for this behavior. These are probably +> bugs. --[[Joey]] + +>> OK, I believe my updated branch gives `autoindex` the same behaviour +>> as auto-creation of tags. The `auto-del-create-del` and +>> `create-del-auto` use cases work the same as for tags on my demo wiki. --s