X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/0d4277ee471dfdd65fff549769a98811f24eb43c..81aa58e7ca0118fbb6e1b7f53e47f01d260cdbff:/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn?ds=inline diff --git a/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn b/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn index 5c5b01431..ca3599660 100644 --- a/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn +++ b/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn @@ -56,23 +56,12 @@ sub formbuilder_setup (@) { I believe this could be worked around simply by re-enabling that field and allowing the user to specify an email there by hand, making a note that the OpenID provider's email is used by default. -Here's the dumbest [[!taglink patch]] that actually fixes the problem for me: +[[!template id=gitbranch branch=anarcat/openid_email author="[[anarcat]]"]] -[[!format diff """ -diff --git a/IkiWiki/Plugin/openid.pm b/IkiWiki/Plugin/openid.pm -index e3b9982..df87ba3 100644 ---- a/IkiWiki/Plugin/openid.pm -+++ b/IkiWiki/Plugin/openid.pm -@@ -104,7 +104,6 @@ sub formbuilder_setup (@) { - size => 1, force => 1, - fieldset => "login", - comment => $session->param("name")); -- $form->field(name => "email", type => "hidden"); - } - } - -"""]] +The dumbest [[!taglink patch]] that actually fixes the problem for me is in the branch mentionned here. It would probably be better to add a comment on the field as indicated above, but it's a good proof of concept. Any other ideas? --[[anarcat]] + +> Note: it seems that my email *is* given by my OpenID provider, no idea why this is not working, but the fix proposed in my branch works. --[[anarcat]]