X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/blobdiff_plain/0bb605baf8702d1a5d1ee16f52b07840d88616e7..42ffdb661c4a070cd0291bc27b4609f51c3777a2:/IkiWiki/CGI.pm

diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index f589ca41d..3b4228b75 100644
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -4,7 +4,8 @@ use warnings;
 use strict;
 use IkiWiki;
 use IkiWiki::UserInfo;
-use encoding 'utf8'; # force use of utf8 for io layer
+use open qw{:utf8 :std};
+use Encode;
 
 package IkiWiki;
 
@@ -33,14 +34,14 @@ sub cgi_recentchanges ($) { #{{{
 	
 	unlockwiki();
 
-	# Force reading the template as utf-8, necessary if
-	# rcs_recentchanges returns true utf-8 strings.
-	open(TMPL, "<:utf8", "$config{templatedir}/recentchanges.tmpl");
-	my $template=HTML::Template->new(filehandle => *TMPL);
-	close(TMPL);
-	my $template=HTML::Template->new(
-		filename => "$config{templatedir}/recentchanges.tmpl"
-	);
+	# Optimisation: building recentchanges means calculating lots of
+	# links. Memoizing htmllink speeds it up a lot (can't be memoized
+	# during page builds as the return values may change, but they
+	# won't here.)
+	eval q{use Memoize};
+	memoize("htmllink");
+
+	my $template=template("recentchanges.tmpl"); 
 	$template->param(
 		title => "RecentChanges",
 		indexlink => indexlink(),
@@ -75,7 +76,7 @@ sub cgi_signin ($$) { #{{{
 		action => $config{cgiurl},
 		header => 0,
 		template => (-e "$config{templatedir}/signin.tmpl" ?
-		              "$config{templatedir}/signin.tmpl" : ""),
+			     {template_params("signin.tmpl")} : ""),
 		stylesheet => styleurl(),
 	);
 	
@@ -188,9 +189,7 @@ sub cgi_signin ($$) { #{{{
 		}
 		elsif ($form->submitted eq 'Mail Password') {
 			my $user_name=$form->field("name");
-			my $template=HTML::Template->new(
-				filename => "$config{templatedir}/passwordmail.tmpl"
-			);
+			my $template=template("passwordmail.tmpl");
 			$template->param(
 				user_name => $user_name,
 				user_password => userinfo_get($user_name, "password"),
@@ -242,7 +241,7 @@ sub cgi_prefs ($$) { #{{{
 		params => $q,
 		action => $config{cgiurl},
 		template => (-e "$config{templatedir}/prefs.tmpl" ?
-		              "$config{templatedir}/prefs.tmpl" : ""),
+			     {template_params("prefs.tmpl")} : ""),
 		stylesheet => styleurl(),
 	);
 	my @buttons=("Save Preferences", "Logout", "Cancel");
@@ -311,23 +310,27 @@ sub cgi_editpage ($$) { #{{{
 		params => $q,
 		action => $config{cgiurl},
 		table => 0,
-		template => "$config{templatedir}/editpage.tmpl"
+		template => {template_params("editpage.tmpl")},
 	);
 	my @buttons=("Save Page", "Preview", "Cancel");
 	
 	# This untaint is safe because titlepage removes any problimatic
 	# characters.
-	my ($page)=titlepage(possibly_foolish_untaint(lc($form->param('page'))));
+	my ($page)=decode_utf8($form->param('page'));
+	$page=titlepage(possibly_foolish_untaint(lc($page)));
 	if (! defined $page || ! length $page ||
 	    $page=~/$config{wiki_file_prune_regexp}/ || $page=~/^\//) {
 		error("bad page name");
 	}
 	$page=lc($page);
 	
-	my $file=$page.$config{default_pageext};
+	my $file;
 	if (exists $pagesources{lc($page)}) {
 		$file=$pagesources{lc($page)};
 	}
+	else {
+		$file=$page.".".$config{default_pageext};
+	}
 	my $newfile=0;
 	if (! -e "$config{srcdir}/$file") {
 		$newfile=1;
@@ -360,14 +363,14 @@ sub cgi_editpage ($$) { #{{{
 		require IkiWiki::Render;
 		# Apparently FormBuilder doesn't not treat input as
 		# utf-8, so decode from it.
-		require Encode;
-		my $content = Encode::decode_utf8($form->field('editcontent'));
+		my $content=decode_utf8($form->field('editcontent'));
+		my $comments=decode_utf8($form->field('comments'));
 		$form->field(name => "editcontent",
 				value => $content, force => 1);
 		$form->field(name => "comments",
-				value => Encode::decode_utf8($form->field('comments')), force => 1);
+				value => $comments, force => 1);
 		$form->tmpl_param("page_preview",
-			htmlize($config{default_pageext},
+			htmlize(pagetype($file),
 				linkify($page, $page, $content)));
 	}
 	else {
@@ -449,8 +452,7 @@ sub cgi_editpage ($$) { #{{{
 		page_locked($page, $session);
 		
 		# Decode utf-8 since FormBuilder does not
-		require Encode;
-		my $content=Encode::decode_utf8($form->field('editcontent'));
+		my $content=decode_utf8($form->field('editcontent'));
 
 		$content=~s/\r\n/\n/g;
 		$content=~s/\r/\n/g;
@@ -466,7 +468,7 @@ sub cgi_editpage ($$) { #{{{
 		}
 		if (defined $form->field('comments') &&
 		    length $form->field('comments')) {
-			$message.=Encode::decode_utf8(": ".$form->field('comments'));
+			$message.=": ".decode_utf8($form->field('comments'));
 		}
 		
 		if ($config{rcs}) {
@@ -485,6 +487,7 @@ sub cgi_editpage ($$) { #{{{
 					force => 1);
 				$form->tmpl_param("page_conflict", 1);
 				$form->field("editcontent", value => $conflict, force => 1);
+				$form->field(name => "comments", value => decode_utf8($form->field('comments')), force => 1);
 				$form->field("do", "edit)");
 				$form->tmpl_param("page_select", 0);
 				$form->field(name => "page", type => 'hidden');