slight clarification

[git.ikiwiki.info.git] / IkiWiki / Plugin / img.pm

diff --git a/IkiWiki/Plugin/img.pm b/IkiWiki/Plugin/img.pm
index 223b5a11f3e1250ae3dca43551f4601f47508894..f06121578266bedc92027a0624cd05a21cdf6c0f 100644 (file)
--- a/IkiWiki/Plugin/img.pm
+++ b/IkiWiki/Plugin/img.pm
@@ -19,6 +19,7 @@ sub getsetup () {
                plugin => {
                        safe => 1,
                        rebuild => undef,
                plugin => {
                        safe => 1,
                        rebuild => undef,

+                       section => "widget",

                },
 }
 
                },
 }
 


@@ -26,6 +27,10 @@ sub preprocess (@) {
        my ($image) = $_[0] =~ /$config{wiki_file_regexp}/; # untaint
        my %params=@_;
 
        my ($image) = $_[0] =~ /$config{wiki_file_regexp}/; # untaint
        my %params=@_;
 

+       if (! defined $image) {
+               error("bad image filename");
+       }
+

        if (exists $imgdefaults{$params{page}}) {
                foreach my $key (keys %{$imgdefaults{$params{page}}}) {
                        if (! exists $params{$key}) {
        if (exists $imgdefaults{$params{page}}) {
                foreach my $key (keys %{$imgdefaults{$params{page}}}) {
                        if (! exists $params{$key}) {


@@ -44,6 +49,7 @@ sub preprocess (@) {
        }
 
        add_link($params{page}, $image);
        }
 
        add_link($params{page}, $image);

+       add_depends($params{page}, $image);

 
        # optimisation: detect scan mode, and avoid generating the image
        if (! defined wantarray) {
 
        # optimisation: detect scan mode, and avoid generating the image
        if (! defined wantarray) {


@@ -69,8 +75,6 @@ sub preprocess (@) {
        my ($dwidth, $dheight);
 
        if ($params{size} ne 'full') {
        my ($dwidth, $dheight);
 
        if ($params{size} ne 'full') {

-               add_depends($params{page}, $image);
-

                my ($w, $h) = ($params{size} =~ /^(\d*)x(\d*)$/);
                error sprintf(gettext('wrong size format "%s" (should be WxH)'), $params{size})
                        unless (defined $w && defined $h &&
                my ($w, $h) = ($params{size} =~ /^(\d*)x(\d*)$/);
                error sprintf(gettext('wrong size format "%s" (should be WxH)'), $params{size})
                        unless (defined $w && defined $h &&


@@ -156,30 +160,38 @@ sub preprocess (@) {
                '" height="'.$dheight.'"'.
                (exists $params{alt} ? ' alt="'.$params{alt}.'"' : '').
                (exists $params{title} ? ' title="'.$params{title}.'"' : '').
                '" height="'.$dheight.'"'.
                (exists $params{alt} ? ' alt="'.$params{alt}.'"' : '').
                (exists $params{title} ? ' title="'.$params{title}.'"' : '').

-               (exists $params{align} ? ' align="'.$params{align}.'"' : '').

                (exists $params{class} ? ' class="'.$params{class}.'"' : '').
                (exists $params{class} ? ' class="'.$params{class}.'"' : '').

+               (exists $params{align} && ! exists $params{caption} ? ' align="'.$params{align}.'"' : '').

                (exists $params{id} ? ' id="'.$params{id}.'"' : '').
                ' />';
 
                (exists $params{id} ? ' id="'.$params{id}.'"' : '').
                ' />';
 

-       if (! defined $params{link} || lc($params{link}) eq 'yes') {
-               $imgtag='<a href="'.$fileurl.'">'.$imgtag.'</a>';
+       my $link;
+       if (! defined $params{link}) {
+               $link=$fileurl;

        }
        elsif ($params{link} =~ /^\w+:\/\//) {
        }
        elsif ($params{link} =~ /^\w+:\/\//) {

-               $imgtag='<a href="'.$params{link}.'">'.$imgtag.'</a>';
+               $link=$params{link};
+       }
+
+       if (defined $link) {
+               $imgtag='<a href="'.$link.'">'.$imgtag.'</a>';

        }
        else {
                my $b = bestlink($params{page}, $params{link});
        
                if (length $b) {
        }
        else {
                my $b = bestlink($params{page}, $params{link});
        
                if (length $b) {

-                       add_depends($params{page}, $b);
+                       add_depends($params{page}, $b, deptype("presence"));

                        $imgtag=htmllink($params{page}, $params{destpage},
                                $params{link}, linktext => $imgtag,
                        $imgtag=htmllink($params{page}, $params{destpage},
                                $params{link}, linktext => $imgtag,

-                               noimageinline => 1);
+                               noimageinline => 1,
+                       );

                }
        }
 
        if (exists $params{caption}) {
                }
        }
 
        if (exists $params{caption}) {

-               return '<table class="img">'.
+               return '<table class="img'.
+                       (exists $params{align} ? " align-$params{align}" : "").
+                       '">'.

                        '<caption>'.$params{caption}.'</caption>'.
                        '<tr><td>'.$imgtag.'</td></tr>'.
                        '</table>';
                        '<caption>'.$params{caption}.'</caption>'.
                        '<tr><td>'.$imgtag.'</td></tr>'.
                        '</table>';