unfuzzy

[git.ikiwiki.info.git] / IkiWiki / CGI.pm

diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index c399ad8a6c414de4af8b374918542398a1e84ce2..96b9dab6193f94cb07cc4f420288b33e93134640 100644 (file)
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -45,8 +45,12 @@ sub page_locked ($$;$) { #{{{
                my $locked_pages=userinfo_get($admin, "locked_pages");
                if (pagespec_match($page, userinfo_get($admin, "locked_pages"))) {
                        return 1 if $nonfatal;
                my $locked_pages=userinfo_get($admin, "locked_pages");
                if (pagespec_match($page, userinfo_get($admin, "locked_pages"))) {
                        return 1 if $nonfatal;

-                       error(htmllink("", "", $page, 1)." is locked by ".
-                             htmllink("", "", $admin, 1)." and cannot be edited.");
+
+                       #translators: The first parameter is a page name,
+                       #translators: second is the user who locked it.
+                       error(sprintf(gettext("%s is locked by %s and cannot be edited"),
+                               htmllink("", "", $page, 1),
+                               userlink($admin)));

                }
        }
 
                }
        }
 


@@ -67,8 +71,6 @@ sub decode_form_utf8 ($) { #{{{
 sub cgi_recentchanges ($) { #{{{
        my $q=shift;
        
 sub cgi_recentchanges ($) { #{{{
        my $q=shift;
        

-       unlockwiki();
-

        # Optimisation: building recentchanges means calculating lots of
        # links. Memoizing htmllink speeds it up a lot (can't be memoized
        # during page builds as the return values may change, but they
        # Optimisation: building recentchanges means calculating lots of
        # links. Memoizing htmllink speeds it up a lot (can't be memoized
        # during page builds as the return values may change, but they


@@ -79,28 +81,18 @@ sub cgi_recentchanges ($) { #{{{
 
        eval q{use Time::Duration};
        error($@) if $@;
 
        eval q{use Time::Duration};
        error($@) if $@;

-       eval q{use CGI 'escapeHTML'};
-       error($@) if $@;

 
        my $changelog=[rcs_recentchanges(100)];
        foreach my $change (@$changelog) {
                $change->{when} = concise(ago($change->{when}));
 
 
        my $changelog=[rcs_recentchanges(100)];
        foreach my $change (@$changelog) {
                $change->{when} = concise(ago($change->{when}));
 

-               if ($change->{user} =~ m!^https?://! &&
-                   eval q{use Net::OpenID::VerifiedIdentity; 1} && !$@) {
-                       # Munge user-urls, as used by eg, OpenID.
-                       my $oid=Net::OpenID::VerifiedIdentity->new(identity => $change->{user});
-                       $change->{user} = "<a href=\"".$change->{user}."\">".escapeHTML($oid->display)."</a>";
-               }
-               else {
-                       $change->{user} = htmllink("", "", escapeHTML($change->{user}), 1);
-               }
+               $change->{user} = userlink($change->{user});

 
                my $is_excess = exists $change->{pages}[10]; # limit pages to first 10
                delete @{$change->{pages}}[10 .. @{$change->{pages}}] if $is_excess;
                $change->{pages} = [
                        map {
 
                my $is_excess = exists $change->{pages}[10]; # limit pages to first 10
                delete @{$change->{pages}}[10 .. @{$change->{pages}}] if $is_excess;
                $change->{pages} = [
                        map {

-                               $_->{link} = htmllink("", "", $_->{page}, 1);
+                               $_->{link} = htmllink("", "", $_->{page}, 1, 0, pagetitle($_->{page}));

                                $_;
                        } @{$change->{pages}}
                ];
                                $_;
                        } @{$change->{pages}}
                ];


@@ -129,202 +121,61 @@ sub cgi_signin ($$) { #{{{
        error($@) if $@;
        my $form = CGI::FormBuilder->new(
                title => "signin",
        error($@) if $@;
        my $form = CGI::FormBuilder->new(
                title => "signin",

-               fields => [qw(do title page subpage from name password openid_url)],

                header => 1,
                charset => "utf-8",
                method => 'POST',
                header => 1,
                charset => "utf-8",
                method => 'POST',

-               validate => {
-                       confirm_password => {
-                               perl => q{eq $form->field("password")},
-                       },
-                       email => 'EMAIL',
-               },

                required => 'NONE',
                javascript => 0,
                params => $q,
                action => $config{cgiurl},
                header => 0,
                required => 'NONE',
                javascript => 0,
                params => $q,
                action => $config{cgiurl},
                header => 0,

-               template => (-e "$config{templatedir}/signin.tmpl" ?
-                            {template_params("signin.tmpl")} : ""),
+               template => scalar template_params("signin.tmpl"),

                stylesheet => baseurl()."style.css",
        );
                stylesheet => baseurl()."style.css",
        );

-               
-       decode_form_utf8($form);
+       my $buttons=["Login"];

        
        

-       $form->field(name => "name", required => 0);

        $form->field(name => "do", type => "hidden");
        $form->field(name => "do", type => "hidden");

-       $form->field(name => "page", type => "hidden");
-       $form->field(name => "title", type => "hidden");
-       $form->field(name => "from", type => "hidden");
-       $form->field(name => "subpage", type => "hidden");
-       $form->field(name => "password", type => "password", required => 0);
-       if ($config{openid}) {
-               $form->field(name => "openid_url", label => "OpenID",
-                       comment => '('.htmllink("", "", "OpenID", 1, 0, "What's this?").')');
-       }
-       else {
-               $form->field(name => "openid_url", type => "hidden");
-       }
-       if ($form->submitted eq "Register" || $form->submitted eq "Create Account") {
-               $form->title("register");
-               $form->text("");
-               $form->fields(qw(do title page subpage from name password confirm_password email));
-               $form->field(name => "confirm_password", type => "password");
-               $form->field(name => "email", type => "text");
-               $form->field(name => "openid_url", type => "hidden");
-       }
+       

        if ($q->param("do") ne "signin" && !$form->submitted) {
        if ($q->param("do") ne "signin" && !$form->submitted) {

-               $form->text("You need to log in first.");
+               $form->text(gettext("You need to log in first."));

        }
        
        }
        

-       if ($form->submitted) {
-               my $submittype=$form->submitted;
-               # OpenID login uses the Login button, but validates
-               # differently.
-               if ($submittype eq "Login" && $config{openid} && 
-                   length $form->field("openid_url")) {
-                       $submittype="OpenID";
-                       
-                       $form->field(
-                               name => "openid_url",
-                               validate => sub {
-                                       # FIXME: ugh
-                                       IkiWiki::Plugin::openid::validate($q, $session, $form, shift);
-                               },
-                       );
-               }
-
-               # Set required fields based on how form was submitted.
-               my %required=(
-                       "Login" => [qw(name password)],
-                       "Register" => [],
-                       "Create Account" => [qw(name password confirm_password email)],
-                       "Mail Password" => [qw(name)],
-                       "OpenID" => [qw(openid_url)],
-               );
-               foreach my $opt (@{$required{$submittype}}) {
-                       $form->field(name => $opt, required => 1);
-               }
+       run_hooks(formbuilder_setup => sub {
+               shift->(form => $form, cgi => $q, session => $session);
+       });

        
        

-               # Validate password differently depending on how
-               # form was submitted.
-               if ($submittype eq 'Login') {
-                       $form->field(
-                               name => "password",
-                               validate => sub {
-                                       length $form->field("name") &&
-                                       shift eq userinfo_get($form->field("name"), 'password');
-                               },
-                       );
-                       $form->field(name => "name", validate => '/^\w+$/');
-               }
-               elsif ($submittype ne 'OpenID') {
-                       $form->field(name => "password", validate => 'VALUE');
-               }
-               # And make sure the entered name exists when logging
-               # in or sending email, and does not when registering.
-               if ($submittype eq 'Create Account' ||
-                   $submittype eq 'Register') {
-                       $form->field(
-                               name => "name",
-                               validate => sub {
-                                       my $name=shift;
-                                       length $name &&
-                                       $name=~/$config{wiki_file_regexp}/ &&
-                                       ! userinfo_get($name, "regdate");
-                               },
-                       );
-               }
-               elsif ($submittype ne 'OpenID') {
-                       $form->field(
-                               name => "name",
-                               validate => sub {
-                                       my $name=shift;
-                                       length $name &&
-                                       userinfo_get($name, "regdate");
-                               },
-                       );
-               }
+       decode_form_utf8($form);
+
+       if (exists $hooks{formbuilder}) {
+               run_hooks(formbuilder => sub {
+                       shift->(form => $form, cgi => $q, session => $session,
+                               buttons => $buttons);
+               });

        }
        else {
        }
        else {

-               # First time settings.
-               $form->field(name => "name", comment => "use FirstnameLastName");
-               if ($session->param("name")) {
-                       $form->field(name => "name", value => $session->param("name"));
+               if ($form->submitted) {
+                       $form->validate;

                }
                }

+               printheader($session);
+               print misctemplate($form->title, $form->render(submit => $buttons));

        }
        }

+} #}}}

 
 

-       if ($form->submitted && $form->validate) {
-               if ($form->submitted eq 'Login') {
-                       $session->param("name", $form->field("name"));
-                       if (defined $form->field("do") && 
-                           $form->field("do") ne 'signin') {
-                               redirect($q, cgiurl(
-                                       do => $form->field("do"),
-                                       page => $form->field("page"),
-                                       title => $form->field("title"),
-                                       from => $form->field("from"),
-                                       subpage => $form->field("subpage"),
-                               ));
-                       }
-                       else {
-                               redirect($q, $config{url});
-                       }
-               }
-               elsif ($form->submitted eq 'Create Account') {
-                       my $user_name=$form->field('name');
-                       if (userinfo_setall($user_name, {
-                                          'email' => $form->field('email'),
-                                          'password' => $form->field('password'),
-                                          'regdate' => time
-                                        })) {
-                               $form->field(name => "confirm_password", type => "hidden");
-                               $form->field(name => "email", type => "hidden");
-                               $form->text("Account creation successful. Now you can Login.");
-                               printheader($session);
-                               print misctemplate($form->title, $form->render(submit => ["Login"]));
-                       }
-                       else {
-                               error("Error creating account.");
-                       }
-               }
-               elsif ($form->submitted eq 'Mail Password') {
-                       my $user_name=$form->field("name");
-                       my $template=template("passwordmail.tmpl");
-                       $template->param(
-                               user_name => $user_name,
-                               user_password => userinfo_get($user_name, "password"),
-                               wikiurl => $config{url},
-                               wikiname => $config{wikiname},
-                               REMOTE_ADDR => $ENV{REMOTE_ADDR},
-                       );
-                       
-                       eval q{use Mail::Sendmail};
-                       error($@) if $@;
-                       sendmail(
-                               To => userinfo_get($user_name, "email"),
-                               From => "$config{wikiname} admin <$config{adminemail}>",
-                               Subject => "$config{wikiname} information",
-                               Message => $template->output,
-                       ) or error("Failed to send mail");
-                       
-                       $form->text("Your password has been emailed to you.");
-                       $form->field(name => "name", required => 0);
-                       printheader($session);
-                       print misctemplate($form->title, $form->render(submit => ["Login", "Mail Password"]));
-               }
-               elsif ($form->submitted eq "Register") {
-                       printheader($session);
-                       print misctemplate($form->title, $form->render(submit => ["Create Account"]));
-               }
-       }
-       elsif ($form->submitted eq "Create Account") {
-               printheader($session);
-               print misctemplate($form->title, $form->render(submit => ["Create Account"]));
+sub cgi_postsignin ($$) { #{{{
+       my $q=shift;
+       my $session=shift;
+
+       # Continue with whatever was being done before the signin process.
+       if (defined $q->param("do") && $q->param("do") ne "signin" &&
+           defined $session->param("postsignin")) {
+               my $postsignin=CGI->new($session->param("postsignin"));
+               $session->clear("postsignin");
+               cgi($postsignin, $session);
+               cgi_savesession($session);
+               exit;

        }
        else {
        }
        else {

-               printheader($session);
-               print misctemplate($form->title, $form->render(submit => ["Login", "Register", "Mail Password"]));
+               redirect($q, $config{url});

        }
 } #}}}
 
        }
 } #}}}
 


@@ -336,49 +187,39 @@ sub cgi_prefs ($$) { #{{{
        error($@) if $@;
        my $form = CGI::FormBuilder->new(
                title => "preferences",
        error($@) if $@;
        my $form = CGI::FormBuilder->new(
                title => "preferences",

-               fields => [qw(do name password confirm_password email 
-                             subscriptions locked_pages)],

                header => 0,
                charset => "utf-8",
                method => 'POST',
                validate => {
                header => 0,
                charset => "utf-8",
                method => 'POST',
                validate => {

-                       confirm_password => {
-                               perl => q{eq $form->field("password")},
-                       },

                        email => 'EMAIL',
                },
                required => 'NONE',
                javascript => 0,
                params => $q,
                action => $config{cgiurl},
                        email => 'EMAIL',
                },
                required => 'NONE',
                javascript => 0,
                params => $q,
                action => $config{cgiurl},

-               template => (-e "$config{templatedir}/prefs.tmpl" ?
-                            {template_params("prefs.tmpl")} : ""),
+               template => scalar template_params("prefs.tmpl"),

                stylesheet => baseurl()."style.css",
        );
                stylesheet => baseurl()."style.css",
        );

-       my @buttons=("Save Preferences", "Logout", "Cancel");
+       my $buttons=["Save Preferences", "Logout", "Cancel"];
+
+       run_hooks(formbuilder_setup => sub {
+               shift->(form => $form, cgi => $q, session => $session);
+       });

        
        

-       my $user_name=$session->param("name");

        $form->field(name => "do", type => "hidden");
        $form->field(name => "do", type => "hidden");

-       $form->field(name => "name", disabled => 1,
-               value => $user_name, force => 1);
-       $form->field(name => "password", type => "password");
-       $form->field(name => "confirm_password", type => "password");
+       $form->field(name => "email", size => 50);

        $form->field(name => "subscriptions", size => 50,
                comment => "(".htmllink("", "", "PageSpec", 1).")");
        $form->field(name => "locked_pages", size => 50,
                comment => "(".htmllink("", "", "PageSpec", 1).")");
        $form->field(name => "banned_users", size => 50);
        
        $form->field(name => "subscriptions", size => 50,
                comment => "(".htmllink("", "", "PageSpec", 1).")");
        $form->field(name => "locked_pages", size => 50,
                comment => "(".htmllink("", "", "PageSpec", 1).")");
        $form->field(name => "banned_users", size => 50);
        

+       my $user_name=$session->param("name");

        if (! is_admin($user_name)) {
                $form->field(name => "locked_pages", type => "hidden");
                $form->field(name => "banned_users", type => "hidden");
        }
 
        if (! is_admin($user_name)) {
                $form->field(name => "locked_pages", type => "hidden");
                $form->field(name => "banned_users", type => "hidden");
        }
 

-       if ($config{httpauth}) {
-               $form->field(name => "password", type => "hidden");
-               $form->field(name => "confirm_password", type => "hidden");
-       }
-       

        if (! $form->submitted) {
                $form->field(name => "email", force => 1,
                        value => userinfo_get($user_name, "email"));
        if (! $form->submitted) {
                $form->field(name => "email", force => 1,
                        value => userinfo_get($user_name, "email"));


@@ -403,9 +244,9 @@ sub cgi_prefs ($$) { #{{{
                redirect($q, $config{url});
                return;
        }
                redirect($q, $config{url});
                return;
        }

-       elsif ($form->submitted eq "Save Preferences" && $form->validate) {
-               foreach my $field (qw(password email subscriptions locked_pages)) {
-                       if (length $form->field($field)) {
+       elsif ($form->submitted eq 'Save Preferences' && $form->validate) {
+               foreach my $field (qw(email subscriptions locked_pages)) {
+                       if (defined $form->field($field) && length $form->field($field)) {

                                userinfo_set($user_name, $field, $form->field($field)) || error("failed to set $field");
                        }
                }
                                userinfo_set($user_name, $field, $form->field($field)) || error("failed to set $field");
                        }
                }


@@ -413,11 +254,19 @@ sub cgi_prefs ($$) { #{{{
                        set_banned_users(grep { ! is_admin($_) }
                                        split(' ', $form->field("banned_users")));
                }
                        set_banned_users(grep { ! is_admin($_) }
                                        split(' ', $form->field("banned_users")));
                }

-               $form->text("Preferences saved.");
+               $form->text(gettext("Preferences saved."));

        }
        
        }
        

-       printheader($session);
-       print misctemplate($form->title, $form->render(submit => \@buttons));
+       if (exists $hooks{formbuilder}) {
+               run_hooks(formbuilder => sub {
+                       shift->(form => $form, cgi => $q, session => $session,
+                               buttons => $buttons);
+               });
+       }
+       else {
+               printheader($session);
+               print misctemplate($form->title, $form->render(submit => $buttons));
+       }

 } #}}}
 
 sub cgi_editpage ($$) { #{{{
 } #}}}
 
 sub cgi_editpage ($$) { #{{{


@@ -427,15 +276,8 @@ sub cgi_editpage ($$) { #{{{
        my @fields=qw(do rcsinfo subpage from page type editcontent comments);
        my @buttons=("Save Page", "Preview", "Cancel");
        
        my @fields=qw(do rcsinfo subpage from page type editcontent comments);
        my @buttons=("Save Page", "Preview", "Cancel");
        

-       eval q{use CGI::FormBuilder; use CGI::FormBuilder::Template::HTML};
+       eval q{use CGI::FormBuilder};

        error($@) if $@;
        error($@) if $@;

-       my $renderer=CGI::FormBuilder::Template::HTML->new(
-               fields => \@fields,
-               template_params("editpage.tmpl"),
-       );
-       run_hooks(pagetemplate => sub {
-               shift->(page => "", destpage => "", template => $renderer->engine);
-       });

        my $form = CGI::FormBuilder->new(
                fields => \@fields,
                header => 1,
        my $form = CGI::FormBuilder->new(
                fields => \@fields,
                header => 1,


@@ -449,17 +291,20 @@ sub cgi_editpage ($$) { #{{{
                params => $q,
                action => $config{cgiurl},
                table => 0,
                params => $q,
                action => $config{cgiurl},
                table => 0,

-               template => $renderer,
+               template => scalar template_params("editpage.tmpl"),

        );
        
        );
        

+       run_hooks(formbuilder_setup => sub {
+               shift->(form => $form, cgi => $q, session => $session);
+       });
+       

        decode_form_utf8($form);
        
        # This untaint is safe because titlepage removes any problematic
        # characters.
        my ($page)=$form->field('page');
        $page=titlepage(possibly_foolish_untaint($page));
        decode_form_utf8($form);
        
        # This untaint is safe because titlepage removes any problematic
        # characters.
        my ($page)=$form->field('page');
        $page=titlepage(possibly_foolish_untaint($page));

-       if (! defined $page || ! length $page ||
-           $page=~/$config{wiki_file_prune_regexp}/ || $page=~/^\//) {
+       if (! defined $page || ! length $page || file_pruned($page, $config{srcdir}) || $page=~/^\//) {

                error("bad page name");
        }
        
                error("bad page name");
        }
        


@@ -549,7 +394,7 @@ sub cgi_editpage ($$) { #{{{
                        my $best_loc;
                        if (! defined $from || ! length $from ||
                            $from ne $form->field('from') ||
                        my $best_loc;
                        if (! defined $from || ! length $from ||
                            $from ne $form->field('from') ||

-                           $from=~/$config{wiki_file_prune_regexp}/ ||
+                           file_pruned($from, $config{srcdir}) ||

                            $from=~/^\// ||
                            $form->submitted eq "Preview") {
                                @page_locs=$best_loc=$page;
                            $from=~/^\// ||
                            $form->submitted eq "Preview") {
                                @page_locs=$best_loc=$page;


@@ -559,7 +404,7 @@ sub cgi_editpage ($$) { #{{{
                                $dir=~s![^/]+/+$!!;
                                
                                if ((defined $form->field('subpage') && length $form->field('subpage')) ||
                                $dir=~s![^/]+/+$!!;
                                
                                if ((defined $form->field('subpage') && length $form->field('subpage')) ||

-                                   $page eq 'discussion') {
+                                   $page eq gettext('discussion')) {

                                        $best_loc="$from/$page";
                                }
                                else {
                                        $best_loc="$from/$page";
                                }
                                else {


@@ -573,6 +418,8 @@ sub cgi_editpage ($$) { #{{{
                                        push @page_locs, $dir.$page;
                                }
                        }
                                        push @page_locs, $dir.$page;
                                }
                        }

+                       push @page_locs, "$config{userdir}/$page"
+                               if length $config{userdir};

 
                        @page_locs = grep {
                                ! exists $pagecase{lc $_} &&
 
                        @page_locs = grep {
                                ! exists $pagecase{lc $_} &&


@@ -596,7 +443,7 @@ sub cgi_editpage ($$) { #{{{
                                options => \@page_locs, value => $best_loc);
                        $form->field(name => "type", type => 'select',
                                options => \@page_types);
                                options => \@page_locs, value => $best_loc);
                        $form->field(name => "type", type => 'select',
                                options => \@page_types);

-                       $form->title("creating ".pagetitle($page));
+                       $form->title(sprintf(gettext("creating %s"), pagetitle($page)));

                }
                elsif ($form->field("do") eq "edit") {
                        page_locked($page, $session);
                }
                elsif ($form->field("do") eq "edit") {
                        page_locked($page, $session);


@@ -613,7 +460,7 @@ sub cgi_editpage ($$) { #{{{
                        $form->tmpl_param("page_select", 0);
                        $form->field(name => "page", type => 'hidden');
                        $form->field(name => "type", type => 'hidden');
                        $form->tmpl_param("page_select", 0);
                        $form->field(name => "page", type => 'hidden');
                        $form->field(name => "type", type => 'hidden');

-                       $form->title("editing ".pagetitle($page));
+                       $form->title(sprintf(gettext("editing %s"), pagetitle($page)));

                }
                
                print $form->render(submit => \@buttons);
                }
                
                print $form->render(submit => \@buttons);


@@ -628,20 +475,13 @@ sub cgi_editpage ($$) { #{{{
                $content=~s/\r/\n/g;
                writefile($file, $config{srcdir}, $content);
                
                $content=~s/\r/\n/g;
                writefile($file, $config{srcdir}, $content);
                

-               my $message="web commit ";
-               if (defined $session->param("name") && 
-                   length $session->param("name")) {
-                       $message.="by ".$session->param("name");
-               }
-               else {
-                       $message.="from $ENV{REMOTE_ADDR}";
-               }
-               if (defined $form->field('comments') &&
-                   length $form->field('comments')) {
-                       $message.=": ".$form->field('comments');
-               }
-               

                if ($config{rcs}) {
                if ($config{rcs}) {

+                       my $message="";
+                       if (defined $form->field('comments') &&
+                           length $form->field('comments')) {
+                               $message=$form->field('comments');
+                       }
+                       

                        if ($newfile) {
                                rcs_add($file);
                        }
                        if ($newfile) {
                                rcs_add($file);
                        }


@@ -650,7 +490,8 @@ sub cgi_editpage ($$) { #{{{
                        # presumably the commit will trigger an update
                        # of the wiki
                        my $conflict=rcs_commit($file, $message,
                        # presumably the commit will trigger an update
                        # of the wiki
                        my $conflict=rcs_commit($file, $message,

-                               $form->field("rcsinfo"));
+                               $form->field("rcsinfo"),
+                               $session->param("name"), $ENV{REMOTE_ADDR});

                
                        if (defined $conflict) {
                                $form->field(name => "rcsinfo", value => rcs_prepedit($file),
                
                        if (defined $conflict) {
                                $form->field(name => "rcsinfo", value => rcs_prepedit($file),


@@ -662,7 +503,7 @@ sub cgi_editpage ($$) { #{{{
                                $form->tmpl_param("page_select", 0);
                                $form->field(name => "page", type => 'hidden');
                                $form->field(name => "type", type => 'hidden');
                                $form->tmpl_param("page_select", 0);
                                $form->field(name => "page", type => 'hidden');
                                $form->field(name => "type", type => 'hidden');

-                               $form->title("editing $page");
+                               $form->title(sprintf(gettext("editing %s"), $page));

                                print $form->render(submit => \@buttons);
                                return;
                        }
                                print $form->render(submit => \@buttons);
                                return;
                        }


@@ -679,14 +520,42 @@ sub cgi_editpage ($$) { #{{{
        }
 } #}}}
 
        }
 } #}}}
 

-sub cgi () { #{{{
-       eval q{use CGI; use CGI::Session};
-       error($@) if $@;
+sub cgi_getsession ($) { #{{{
+       my $q=shift;
+
+       eval q{use CGI::Session};
+       CGI::Session->name("ikiwiki_session_".encode_utf8($config{wikiname}));

        
        

-       my $q=CGI->new;
+       my $oldmask=umask(077);
+       my $session = CGI::Session->new("driver:DB_File", $q,
+               { FileName => "$config{wikistatedir}/sessions.db" });
+       umask($oldmask);
+
+       return $session;
+} #}}}
+
+sub cgi_savesession ($) { #{{{
+       my $session=shift;
+
+       # Force session flush with safe umask.
+       my $oldmask=umask(077);
+       $session->flush;
+       umask($oldmask);
+}
+
+sub cgi (;$$) { #{{{
+       my $q=shift;
+       my $session=shift;
+
+       if (! $q) {
+               eval q{use CGI};
+               error($@) if $@;

        
        

-       run_hooks(cgi => sub { shift->($q) });
+               $q=CGI->new;

        
        

+               run_hooks(cgi => sub { shift->($q) });
+       }
+

        my $do=$q->param('do');
        if (! defined $do || ! length $do) {
                my $error = $q->cgi_error;
        my $do=$q->param('do');
        if (! defined $do || ! length $do) {
                my $error = $q->cgi_error;


@@ -706,13 +575,13 @@ sub cgi () { #{{{
        elsif ($do eq 'hyperestraier') {
                cgi_hyperestraier();
        }
        elsif ($do eq 'hyperestraier') {
                cgi_hyperestraier();
        }

+
+       # Need to lock the wiki before getting a session.
+       lockwiki();

        
        

-       CGI::Session->name("ikiwiki_session_".encode_utf8($config{wikiname}));
-       
-       my $oldmask=umask(077);
-       my $session = CGI::Session->new("driver:DB_File", $q,
-               { FileName => "$config{wikistatedir}/sessions.db" });
-       umask($oldmask);
+       if (! $session) {
+               $session=cgi_getsession($q);
+       }

        
        # Auth hooks can sign a user in.
        if ($do ne 'signin' && ! defined $session->param("name")) {
        
        # Auth hooks can sign a user in.
        if ($do ne 'signin' && ! defined $session->param("name")) {


@@ -734,24 +603,25 @@ sub cgi () { #{{{
 
        # Everything below this point needs the user to be signed in.
        if (((! $config{anonok} || $do eq 'prefs') &&
 
        # Everything below this point needs the user to be signed in.
        if (((! $config{anonok} || $do eq 'prefs') &&

-            (! $config{httpauth}) &&

             (! defined $session->param("name") ||
             ! userinfo_get($session->param("name"), "regdate")))
             || $do eq 'signin') {
             (! defined $session->param("name") ||
             ! userinfo_get($session->param("name"), "regdate")))
             || $do eq 'signin') {

+               if ($do ne 'signin' && ! defined $session->param("postsignin")) {
+                       $session->param(postsignin => $ENV{QUERY_STRING});
+               }

                cgi_signin($q, $session);
                cgi_signin($q, $session);

-       
-               # Force session flush with safe umask.
-               my $oldmask=umask(077);
-               $session->flush;
-               umask($oldmask);
-               
+               cgi_savesession($session);

                return;
        }
                return;
        }

+       elsif (defined $session->param("postsignin")) {
+               cgi_postsignin($q, $session);
+       }

 
        if (defined $session->param("name") && userinfo_get($session->param("name"), "banned")) {
                print $q->header(-status => "403 Forbidden");
                $session->delete();
 
        if (defined $session->param("name") && userinfo_get($session->param("name"), "banned")) {
                print $q->header(-status => "403 Forbidden");
                $session->delete();

-               print "You are banned.";
+               print gettext("You are banned.");
+               cgi_savesession($session);

                exit;
        }
        
                exit;
        }
        


@@ -763,6 +633,7 @@ sub cgi () { #{{{
        }
        elsif ($do eq 'blog') {
                my $page=titlepage(decode_utf8($q->param('title')));
        }
        elsif ($do eq 'blog') {
                my $page=titlepage(decode_utf8($q->param('title')));

+               $page=~s/(\/)/"__".ord($1)."__"/eg; # escape slashes too

                # if the page already exists, munge it to be unique
                my $from=$q->param('from');
                my $add="";
                # if the page already exists, munge it to be unique
                my $from=$q->param('from');
                my $add="";


@@ -775,9 +646,40 @@ sub cgi () { #{{{
                $q->param('do', 'create');
                cgi_editpage($q, $session);
        }
                $q->param('do', 'create');
                cgi_editpage($q, $session);
        }

+       elsif ($do eq 'postsignin') {
+               error(gettext("login failed, perhaps you need to turn on cookies?"));
+       }

        else {
                error("unknown do parameter");
        }
 } #}}}
 
        else {
                error("unknown do parameter");
        }
 } #}}}
 

+sub userlink ($) { #{{{
+       my $user=shift;
+
+       eval q{use CGI 'escapeHTML'};
+       error($@) if $@;
+       if ($user =~ m!^https?://! &&
+           eval q{use Net::OpenID::VerifiedIdentity; 1} && !$@) {
+               # Munge user-urls, as used by eg, OpenID.
+               my $oid=Net::OpenID::VerifiedIdentity->new(identity => $user);
+               my $display=$oid->display;
+               # Convert "user.somehost.com" to "user [somehost.com]".
+               if ($display !~ /\[/) {
+                       $display=~s/^(.*?)\.([^.]+\.[a-z]+)$/$1 [$2]/;
+               }
+               # Convert "http://somehost.com/user" to "user [somehost.com]".
+               if ($display !~ /\[/) {
+                       $display=~s/^https?:\/\/(.+)\/([^\/]+)$/$2 [$1]/;
+               }
+               $display=~s!^https?://!!; # make sure this is removed
+               return "<a href=\"$user\">".escapeHTML($display)."</a>";
+       }
+       else {
+               return htmllink("", "", escapeHTML(
+                       length $config{userdir} ? $config{userdir}."/".$user : $user
+               ), 1);
+       }
+} #}}}
+

 1
 1