-The final `</div>` in [`recentchanges.tmpl`][tmpl] gets wrapped in a
+The final `</div>` in `recentchanges.tmpl` gets wrapped in a
`<p>` tag for some reason, resulting in the following invalid XHTML at
-the end of the [[RecentChanges]] page
+the end of the [[Json.tl.ph]] page
<p></div></p>
+> I'll bet this is fixed if you use the markdown 1.2 prerelease, which has
+> a much less buggy html parser. (Ah, I see below that was the case.)
+> --[[Joey]]
+
Also, there is a problem with the `<img>` tags generated by the smiley
plugin which end up wrapped in a `<pre>` tag in the inline diff output.
`<img>` tags is not allowed within a `<pre>` block. Maybe the smiley
-plugin should be disabled on [[RecentChanges]]?
+plugin should be disabled on [[Json.tl.ph]]?
+
+> See [[Smileys_in_the_block_code]], which is now fixed. --[[Joey]]
See the [validator output][validate] for more details.
- [tmpl]: http://git.ikiwiki.info/?p=ikiwiki;a=blob_plain;f=templates/recentchanges.tmpl;hb=HEAD
[validate]: http://validator.w3.org/check?uri=http://ikiwiki.info/recentchanges/
- - -
Here is a simple patch for the refresh problem. I haven't figured out
what's causing the recentchanges bug yet.
+--[[JasonBlevins]]
- diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm
- index 8a9a538..0afe1c3 100644
- --- a/IkiWiki/Plugin/meta.pm
- +++ b/IkiWiki/Plugin/meta.pm
- @@ -186,7 +186,7 @@ sub preprocess (@) { #{{{
- $value=encode_entities($value);
- }
- my $delay=int(exists $params{delay} ? $params{delay} : 0);
- - my $redir="<meta http-equiv=\"refresh\" content=\"$delay; URL=$value\">";
- + my $redir="<meta http-equiv=\"refresh\" content=\"$delay; URL=$value\" />";
- if (! $safe) {
- $redir=scrub($redir);
- }
+> Thanks, applied that patch. --[[Joey]]
+- - -
---[[JasonBlevins]]
+It turns out that the invalid XHTML on the recent changes page is due to
+a bug in Markdown. I was using the packaged version of markdown in
+Ubuntu (Gutsy and markdown 1.0.1-6). Everything is fine
+after installing the most recent version of Text::Markdown from CPAN.
+
+Note that the above patch for the redirect tag is still applicable and
+the smiley issue remains open. --[[JasonBlevins]]
+
+> This bug is [[done]], all issues are fixed. --[[Joey]]
-[[tag patch]]
+[[!tag patch]]