oops

[git.ikiwiki.info.git] / doc / bugs / Problem_with_toc.pm_plug-in.mdwn

diff --git a/doc/bugs/Problem_with_toc.pm_plug-in.mdwn b/doc/bugs/Problem_with_toc.pm_plug-in.mdwn
index 6b8e5923b66d53c6707275f08f5d75eac404940a..6be5f89b5b9ce62b55d0b922924d5646b435eda9 100644 (file)
--- a/doc/bugs/Problem_with_toc.pm_plug-in.mdwn
+++ b/doc/bugs/Problem_with_toc.pm_plug-in.mdwn
@@ -1,13 +1,15 @@
-Problem with toc.pm plug-in
-===========================
-
 The toc.pm plug-in currently renders empty 'a' tag elements. This seems to confuse at least Firefox, possibly others. The result is that the following text is rendered as an anchor (visible if you style 'a' elements in a different color).
 
 Here is a patch for toc.pm for producing non-empty 'a' elements.
 
+> Thanks for the patch, but I already fixed this in 2.4 using a different
+> approach. I think your patch is slightly broken, an anchor tag isn't
+> really meant to enclose all the html it anchors to, but just be stuck in
+> front of it. --[[Joey]] [[!tag done]]
+
     --- IkiWiki/Plugin/toc.pm.orig     Thu Jun  7 11:53:53 2007
     +++ IkiWiki/Plugin/toc.pm  Thu Jun  7 13:00:00 2007
-    @@ -47,7 +47,7 @@ sub format (@) { #{{{
+    @@ -47,7 +47,7 @@ sub format (@) {
                if ($tagname =~ /^h(\d+)$/i) {
                        my $level=$1;
                        my $anchor="index".++$anchors{$level}."h$level";
@@ -16,7 +18,7 @@ Here is a patch for toc.pm for producing non-empty 'a' elements.
        
                        # Take the first header level seen as the topmost level,
                        # even if there are higher levels seen later on.
-    @@ -90,6 +90,16 @@ sub format (@) { #{{{
+    @@ -90,6 +90,16 @@ sub format (@) {
                                        "</a>\n";
                                $p->handler(text => undef);
                        }, "dtext");
@@ -32,4 +34,4 @@ Here is a patch for toc.pm for producing non-empty 'a' elements.
     +                  $page.="</a>$text";
                }
                else {
-                       $page.=$text;
\ No newline at end of file
+                       $page.=$text;