web commit by http://ptecza.myopenid.com/: * Bug report

[git.ikiwiki.info.git] / IkiWiki / CGI.pm

diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index c8c1b63dd5c63d37b4e1854ed58a673920f296f5..8a294e887554bbf0f145cfedc239dd062ba4bfc9 100644 (file)
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -21,7 +21,7 @@ sub printheader ($) { #{{{
 
 } #}}}
 
 
 } #}}}
 

-sub showform ($$$$) { #{{{
+sub showform ($$$$;@) { #{{{

        my $form=shift;
        my $buttons=shift;
        my $session=shift;
        my $form=shift;
        my $buttons=shift;
        my $session=shift;


@@ -35,7 +35,7 @@ sub showform ($$$$) { #{{{
        }
 
        printheader($session);
        }
 
        printheader($session);

-       print misctemplate($form->title, $form->render(submit => $buttons));
+       print misctemplate($form->title, $form->render(submit => $buttons), @_);

 }
 
 sub redirect ($$) { #{{{
 }
 
 sub redirect ($$) { #{{{


@@ -78,9 +78,24 @@ sub check_canedit ($$$;$) { #{{{
 } #}}}
 
 sub decode_cgi_utf8 ($) { #{{{
 } #}}}
 
 sub decode_cgi_utf8 ($) { #{{{

-       my $cgi = shift;
-       foreach my $f ($cgi->param) {
-               $cgi->param($f, map { decode_utf8 $_ } $cgi->param($f));
+       # decode_form_utf8 method is needed for 5.10
+       if ($] < 5.01) {
+               my $cgi = shift;
+               foreach my $f ($cgi->param) {
+                       $cgi->param($f, map { decode_utf8 $_ } $cgi->param($f));
+               }
+       }
+} #}}}
+
+sub decode_form_utf8 ($) { #{{{
+       if ($] >= 5.01) {
+               my $form = shift;
+               foreach my $f ($form->field) {
+                       $form->field(name  => $f,
+                                    value => decode_utf8($form->field($f)),
+                                    force => 1,
+                       );
+               }

        }
 } #}}}
 
        }
 } #}}}
 


@@ -127,10 +142,12 @@ sub cgi_signin ($$) { #{{{
        $form->field(name => "do", type => "hidden", value => "signin",
                force => 1);
        
        $form->field(name => "do", type => "hidden", value => "signin",
                force => 1);
        

+       decode_form_utf8($form);

        run_hooks(formbuilder_setup => sub {
                shift->(form => $form, cgi => $q, session => $session,
                        buttons => $buttons);
        });
        run_hooks(formbuilder_setup => sub {
                shift->(form => $form, cgi => $q, session => $session,
                        buttons => $buttons);
        });

+       decode_form_utf8($form);

 
        if ($form->submitted) {
                $form->validate;
 
        if ($form->submitted) {
                $form->validate;


@@ -161,8 +178,18 @@ sub cgi_prefs ($$) { #{{{
        my $session=shift;
 
        needsignin($q, $session);
        my $session=shift;
 
        needsignin($q, $session);

-

        decode_cgi_utf8($q);
        decode_cgi_utf8($q);

+       
+       # The session id is stored on the form and checked to
+       # guard against CSRF.
+       my $sid=$q->param('sid');
+       if (! defined $sid) {
+               $q->delete_all;
+       }
+       elsif ($sid ne $session->id) {
+               error(gettext("Your login session has expired."));
+       }
+

        eval q{use CGI::FormBuilder};
        error($@) if $@;
        my $form = CGI::FormBuilder->new(
        eval q{use CGI::FormBuilder};
        error($@) if $@;
        my $form = CGI::FormBuilder->new(


@@ -187,13 +214,18 @@ sub cgi_prefs ($$) { #{{{
                ],
        );
        my $buttons=["Save Preferences", "Logout", "Cancel"];
                ],
        );
        my $buttons=["Save Preferences", "Logout", "Cancel"];

-
+       
+       decode_form_utf8($form);

        run_hooks(formbuilder_setup => sub {
                shift->(form => $form, cgi => $q, session => $session,
                        buttons => $buttons);
        });
        run_hooks(formbuilder_setup => sub {
                shift->(form => $form, cgi => $q, session => $session,
                        buttons => $buttons);
        });

+       decode_form_utf8($form);

        
        

-       $form->field(name => "do", type => "hidden");
+       $form->field(name => "do", type => "hidden", value => "prefs",
+               force => 1);
+       $form->field(name => "sid", type => "hidden", value => $session->id,
+               force => 1);

        $form->field(name => "email", size => 50, fieldset => "preferences");
        $form->field(name => "banned_users", size => 50,
                fieldset => "admin");
        $form->field(name => "email", size => 50, fieldset => "preferences");
        $form->field(name => "banned_users", size => 50,
                fieldset => "admin");


@@ -241,11 +273,11 @@ sub cgi_prefs ($$) { #{{{
 sub cgi_editpage ($$) { #{{{
        my $q=shift;
        my $session=shift;
 sub cgi_editpage ($$) { #{{{
        my $q=shift;
        my $session=shift;

+       
+       decode_cgi_utf8($q);

 
        my @fields=qw(do rcsinfo subpage from page type editcontent comments);
        my @buttons=("Save Page", "Preview", "Cancel");
 
        my @fields=qw(do rcsinfo subpage from page type editcontent comments);
        my @buttons=("Save Page", "Preview", "Cancel");

-       
-       decode_cgi_utf8($q);

        eval q{use CGI::FormBuilder};
        error($@) if $@;
        my $form = CGI::FormBuilder->new(
        eval q{use CGI::FormBuilder};
        error($@) if $@;
        my $form = CGI::FormBuilder->new(


@@ -263,10 +295,12 @@ sub cgi_editpage ($$) { #{{{
                wikiname => $config{wikiname},
        );
        
                wikiname => $config{wikiname},
        );
        

+       decode_form_utf8($form);

        run_hooks(formbuilder_setup => sub {
                shift->(form => $form, cgi => $q, session => $session,
                        buttons => \@buttons);
        });
        run_hooks(formbuilder_setup => sub {
                shift->(form => $form, cgi => $q, session => $session,
                        buttons => \@buttons);
        });

+       decode_form_utf8($form);

        
        # This untaint is safe because titlepage removes any problematic
        # characters.
        
        # This untaint is safe because titlepage removes any problematic
        # characters.


@@ -276,6 +310,8 @@ sub cgi_editpage ($$) { #{{{
            file_pruned($page, $config{srcdir}) || $page=~/^\//) {
                error("bad page name");
        }
            file_pruned($page, $config{srcdir}) || $page=~/^\//) {
                error("bad page name");
        }

+
+       my $baseurl=$config{url}."/".htmlpage($page);

        
        my $from;
        if (defined $form->field('from')) {
        
        my $from;
        if (defined $form->field('from')) {


@@ -314,6 +350,8 @@ sub cgi_editpage ($$) { #{{{
        }
 
        $form->field(name => "do", type => 'hidden');
        }
 
        $form->field(name => "do", type => 'hidden');

+       $form->field(name => "sid", type => "hidden", value => $session->id,
+               force => 1);

        $form->field(name => "from", type => 'hidden');
        $form->field(name => "rcsinfo", type => 'hidden');
        $form->field(name => "subpage", type => 'hidden');
        $form->field(name => "from", type => 'hidden');
        $form->field(name => "rcsinfo", type => 'hidden');
        $form->field(name => "subpage", type => 'hidden');


@@ -325,10 +363,9 @@ sub cgi_editpage ($$) { #{{{
        $form->tmpl_param("can_commit", $config{rcs});
        $form->tmpl_param("indexlink", indexlink());
        $form->tmpl_param("helponformattinglink",
        $form->tmpl_param("can_commit", $config{rcs});
        $form->tmpl_param("indexlink", indexlink());
        $form->tmpl_param("helponformattinglink",

-               htmllink("", "", "ikiwiki/formatting",
+               htmllink($page, $page, "ikiwiki/formatting",

                        noimageinline => 1,
                        linktext => "FormattingHelp"));
                        noimageinline => 1,
                        linktext => "FormattingHelp"));

-       $form->tmpl_param("baseurl", baseurl());

        
        if ($form->submitted eq "Cancel") {
                if ($form->field("do") eq "create" && defined $from) {
        
        if ($form->submitted eq "Cancel") {
                if ($form->field("do") eq "create" && defined $from) {


@@ -343,7 +380,14 @@ sub cgi_editpage ($$) { #{{{
                return;
        }
        elsif ($form->submitted eq "Preview") {
                return;
        }
        elsif ($form->submitted eq "Preview") {

+               my $new=not exists $pagesources{$page};
+               if ($new) {
+                       # temporarily record its type
+                       $pagesources{$page}=$page.".".$type;
+               }
+

                my $content=$form->field('editcontent');
                my $content=$form->field('editcontent');

+

                run_hooks(editcontent => sub {
                        $content=shift->(
                                content => $content,
                run_hooks(editcontent => sub {
                        $content=shift->(
                                content => $content,


@@ -353,10 +397,16 @@ sub cgi_editpage ($$) { #{{{
                        );
                });
                $form->tmpl_param("page_preview",
                        );
                });
                $form->tmpl_param("page_preview",

-                       htmlize($page, $type,
-                       linkify($page, "",
+                       htmlize($page, $page, $type,
+                       linkify($page, $page,

                        preprocess($page, $page,
                        filter($page, $page, $content), 0, 1))));
                        preprocess($page, $page,
                        filter($page, $page, $content), 0, 1))));

+       
+               if ($new) {
+                       delete $pagesources{$page};
+               }
+               # previewing may have created files on disk
+               saveindex();

        }
        elsif ($form->submitted eq "Save Page") {
                $form->tmpl_param("page_preview", "");
        }
        elsif ($form->submitted eq "Save Page") {
                $form->tmpl_param("page_preview", "");


@@ -392,9 +442,10 @@ sub cgi_editpage ($$) { #{{{
                                        $dir=~s![^/]+/+$!!;
                                        push @page_locs, $dir.$page;
                                }
                                        $dir=~s![^/]+/+$!!;
                                        push @page_locs, $dir.$page;
                                }

+                       
+                               push @page_locs, "$config{userdir}/$page"
+                                       if length $config{userdir};

                        }
                        }

-                       push @page_locs, "$config{userdir}/$page"
-                               if length $config{userdir};

 
                        @page_locs = grep {
                                ! exists $pagecase{lc $_}
 
                        @page_locs = grep {
                                ! exists $pagecase{lc $_}


@@ -402,8 +453,16 @@ sub cgi_editpage ($$) { #{{{
                        if (! @page_locs) {
                                # hmm, someone else made the page in the
                                # meantime?
                        if (! @page_locs) {
                                # hmm, someone else made the page in the
                                # meantime?

-                               redirect($q, "$config{url}/".htmlpage($page));
-                               return;
+                               if ($form->submitted eq "Preview") {
+                                       # let them go ahead with the edit
+                                       # and resolve the conflict at save
+                                       # time
+                                       @page_locs=$page;
+                               }
+                               else {
+                                       redirect($q, "$config{url}/".htmlpage($page));
+                                       return;
+                               }

                        }
 
                        my @editable_locs = grep {
                        }
 
                        my @editable_locs = grep {


@@ -447,24 +506,33 @@ sub cgi_editpage ($$) { #{{{
                        $form->title(sprintf(gettext("editing %s"), pagetitle($page)));
                }
                
                        $form->title(sprintf(gettext("editing %s"), pagetitle($page)));
                }
                

-               showform($form, \@buttons, $session, $q);
-               saveindex();
+               showform($form, \@buttons, $session, $q, forcebaseurl => $baseurl);

        }
        else {
                # save page
                check_canedit($page, $q, $session);
        }
        else {
                # save page
                check_canedit($page, $q, $session);

+       
+               # The session id is stored on the form and checked to
+               # guard against CSRF. But only if the user is logged in,
+               # as anonok can allow anonymous edits.
+               if (defined $session->param("name")) {
+                       my $sid=$q->param('sid');
+                       if (! defined $sid || $sid ne $session->id) {
+                               error(gettext("Your login session has expired."));
+                       }
+               }

 
                my $exists=-e "$config{srcdir}/$file";
 
                if ($form->field("do") ne "create" && ! $exists &&
 
                my $exists=-e "$config{srcdir}/$file";
 
                if ($form->field("do") ne "create" && ! $exists &&

-                   ! eval { srcfile($file) }) {
+                   ! defined srcfile($file, 1)) {

                        $form->tmpl_param("page_gone", 1);
                        $form->field(name => "do", value => "create", force => 1);
                        $form->tmpl_param("page_select", 0);
                        $form->field(name => "page", type => 'hidden');
                        $form->field(name => "type", type => 'hidden');
                        $form->title(sprintf(gettext("editing %s"), $page));
                        $form->tmpl_param("page_gone", 1);
                        $form->field(name => "do", value => "create", force => 1);
                        $form->tmpl_param("page_select", 0);
                        $form->field(name => "page", type => 'hidden');
                        $form->field(name => "type", type => 'hidden');
                        $form->title(sprintf(gettext("editing %s"), $page));

-                       showform($form, \@buttons, $session, $q);
+                       showform($form, \@buttons, $session, $q, forcebaseurl => $baseurl);

                        return;
                }
                elsif ($form->field("do") eq "create" && $exists) {
                        return;
                }
                elsif ($form->field("do") eq "create" && $exists) {


@@ -478,7 +546,7 @@ sub cgi_editpage ($$) { #{{{
                                value => readfile("$config{srcdir}/$file").
                                         "\n\n\n".$form->field("editcontent"),
                                force => 1);
                                value => readfile("$config{srcdir}/$file").
                                         "\n\n\n".$form->field("editcontent"),
                                force => 1);

-                       showform($form, \@buttons, $session, $q);
+                       showform($form, \@buttons, $session, $q, forcebaseurl => $baseurl);

                        return;
                }
                
                        return;
                }
                


@@ -508,7 +576,8 @@ sub cgi_editpage ($$) { #{{{
                        $form->field(name => "page", type => 'hidden');
                        $form->field(name => "type", type => 'hidden');
                        $form->title(sprintf(gettext("editing %s"), $page));
                        $form->field(name => "page", type => 'hidden');
                        $form->field(name => "type", type => 'hidden');
                        $form->title(sprintf(gettext("editing %s"), $page));

-                       showform($form, \@buttons, $session, $q);
+                       showform($form, \@buttons, $session, $q,
+                               forcebaseurl => $baseurl);

                        return;
                }
                
                        return;
                }
                


@@ -526,7 +595,7 @@ sub cgi_editpage ($$) { #{{{
 
                        # Prevent deadlock with post-commit hook by
                        # signaling to it that it should not try to
 
                        # Prevent deadlock with post-commit hook by
                        # signaling to it that it should not try to

-                       # do anything (except send commit mails).
+                       # do anything.

                        disable_commit_hook();
                        $conflict=rcs_commit($file, $message,
                                $form->field("rcsinfo"),
                        disable_commit_hook();
                        $conflict=rcs_commit($file, $message,
                                $form->field("rcsinfo"),


@@ -539,10 +608,6 @@ sub cgi_editpage ($$) { #{{{
                # may have been committed while the post-commit hook was
                # disabled.
                require IkiWiki::Render;
                # may have been committed while the post-commit hook was
                # disabled.
                require IkiWiki::Render;

-               # Reload index, since the first time it's loaded is before
-               # the wiki is locked, and things may have changed in the
-               # meantime.
-               loadindex();

                refresh();
                saveindex();
 
                refresh();
                saveindex();
 


@@ -556,7 +621,8 @@ sub cgi_editpage ($$) { #{{{
                        $form->field(name => "page", type => 'hidden');
                        $form->field(name => "type", type => 'hidden');
                        $form->title(sprintf(gettext("editing %s"), $page));
                        $form->field(name => "page", type => 'hidden');
                        $form->field(name => "type", type => 'hidden');
                        $form->title(sprintf(gettext("editing %s"), $page));

-                       showform($form, \@buttons, $session, $q);
+                       showform($form, \@buttons, $session, $q,
+                               forcebaseurl => $baseurl);

                        return;
                }
                else {
                        return;
                }
                else {


@@ -571,6 +637,7 @@ sub cgi_getsession ($) { #{{{
        my $q=shift;
 
        eval q{use CGI::Session};
        my $q=shift;
 
        eval q{use CGI::Session};

+       error($@) if $@;

        CGI::Session->name("ikiwiki_session_".encode_utf8($config{wikiname}));
        
        my $oldmask=umask(077);
        CGI::Session->name("ikiwiki_session_".encode_utf8($config{wikiname}));
        
        my $oldmask=umask(077);


@@ -598,7 +665,9 @@ sub cgi (;$$) { #{{{
                eval q{use CGI};
                error($@) if $@;
        
                eval q{use CGI};
                error($@) if $@;
        

+               binmode(STDIN);

                $q=CGI->new;
                $q=CGI->new;

+               binmode(STDIN, ":utf8");

        
                run_hooks(cgi => sub { shift->($q) });
        }
        
                run_hooks(cgi => sub { shift->($q) });
        }


@@ -616,6 +685,7 @@ sub cgi (;$$) { #{{{
        
        # Need to lock the wiki before getting a session.
        lockwiki();
        
        # Need to lock the wiki before getting a session.
        lockwiki();

+       loadindex();

        
        if (! $session) {
                $session=cgi_getsession($q);
        
        if (! $session) {
                $session=cgi_getsession($q);