Exclude working directory from library path (CVE-2016-1238)

[git.ikiwiki.info.git] / doc / bugs / Error_with_external_plugins.mdwn

diff --git a/doc/bugs/Error_with_external_plugins.mdwn b/doc/bugs/Error_with_external_plugins.mdwn
index 35245ace8593fd733c32cbb69210737fe815f08a..065439de8c29272699e739a2be8cc41b995ffc30 100644 (file)
--- a/doc/bugs/Error_with_external_plugins.mdwn
+++ b/doc/bugs/Error_with_external_plugins.mdwn
@@ -36,11 +36,11 @@ I hope someone will understand the problem better than I do, because I have no i
 Regards,    
 -- [[Louis|spalax]]
 
 Regards,    
 -- [[Louis|spalax]]
 

-> I wrote a plugin to monitor what is exchanged between the plugin and Ikiwiki. I ran this with [this version](https://github.com/paternal/ikiwiki-rpcbug/tree/b4ba34a8edd1b97989965af69eddac050bc0a8ba) of my minimal bug example.
+> I used the debug feature provided with `proxy.py` and rebuilt the wiki. I ran this with [this version](https://github.com/paternal/ikiwiki-rpcbug/tree/b4ba34a8edd1b97989965af69eddac050bc0a8ba) of my minimal bug example.

 > 
 > * The bug happens in function [preprocess](https://github.com/paternal/ikiwiki-rpcbug/blob/b4ba34a8edd1b97989965af69eddac050bc0a8ba/plugins/rpcbug#L12-17) (in call to [srcfile](https://github.com/paternal/ikiwiki-rpcbug/blob/b4ba34a8edd1b97989965af69eddac050bc0a8ba/plugins/rpcbug#L15), to be more precise).
 > * The directive causing the bug is called on page [foo](https://github.com/paternal/ikiwiki-rpcbug/blob/b4ba34a8edd1b97989965af69eddac050bc0a8ba/foo.mdwn).
 > 
 > * The bug happens in function [preprocess](https://github.com/paternal/ikiwiki-rpcbug/blob/b4ba34a8edd1b97989965af69eddac050bc0a8ba/plugins/rpcbug#L12-17) (in call to [srcfile](https://github.com/paternal/ikiwiki-rpcbug/blob/b4ba34a8edd1b97989965af69eddac050bc0a8ba/plugins/rpcbug#L15), to be more precise).
 > * The directive causing the bug is called on page [foo](https://github.com/paternal/ikiwiki-rpcbug/blob/b4ba34a8edd1b97989965af69eddac050bc0a8ba/foo.mdwn).

-> * Communication between Ikiwiki and the plugin is [[here|tee]].
+> * Communication between Ikiwiki and the plugin is [[here|debug]].

 > * The resulting HTML (for page `foo`) looks like:
 > 
 > > \[[!rpcbug Erreur: internal error: foo cannot be found in /home/louis/projets/ikiwiki/rpcbug or underlay]]
 > * The resulting HTML (for page `foo`) looks like:
 > 
 > > \[[!rpcbug Erreur: internal error: foo cannot be found in /home/louis/projets/ikiwiki/rpcbug or underlay]]


@@ -76,9 +76,15 @@ Regards,
 >> 
 >> Thus, I think that the bug is in the `proxy.py` python file. On receiving a
 >> `methodCall` (instead of a `methodResponse`) as an answer to a `methodCall`
 >> 
 >> Thus, I think that the bug is in the `proxy.py` python file. On receiving a
 >> `methodCall` (instead of a `methodResponse`) as an answer to a `methodCall`

->> request, `proxy.py` should notice the type of request, and raise an exception,
->> to exit any pending function execution, and call the requested function.
+>> request, `proxy.py` should notice the type of request, and call the requested function.

 >> 
 >> I know Python better than I know Perl, so I can try to fix this.
 >> 
 >> -- [[Louis|spalax]]
 >> 
 >> I know Python better than I know Perl, so I can try to fix this.
 >> 
 >> -- [[Louis|spalax]]

+
+>>> [[!template id=gitbranch author="[[Louis|spalax]]" branch=spalax/paternal/rpcbug
+>>>   browse=https://github.com/paternal/ikiwiki/tree/paternal/rpcbug]]
+>>> [I fixed this bug](https://github.com/paternal/ikiwiki/commit/32da347566a7559ca1ef145880efe961dbcc012f) in a branch on my Ikiwiki clone.
+>>> Please review :)
+>>> 
+>>> -- [[Louis|spalax]]