ikiwiki-mass-rebuild: under $! before setting $) to avoid strange errno issue

[git.ikiwiki.info.git] / ikiwiki-mass-rebuild

diff --git a/ikiwiki-mass-rebuild b/ikiwiki-mass-rebuild
index 5b6a90b9087d4ffdc841c1ed9f10143b1cbddc70..0057beb4f1735f957045adb9ccb1f2893a89bbdc 100755 (executable)
--- a/ikiwiki-mass-rebuild
+++ b/ikiwiki-mass-rebuild
@@ -2,6 +2,19 @@
 use warnings;
 use strict;
 
+sub supplemental_groups {
+       my $user=shift;
+
+       my @list;
+       while (my @fields=getgrent()) {
+               if (grep { $_ eq $user } split(' ', $fields[3])) {
+                       push @list, $fields[2];
+               }
+       }
+
+       return @list;
+}
+
 sub processline {
        my $user=shift;
        my $setup=shift;
@@ -20,15 +33,22 @@ sub processline {
        defined(my $pid = fork) or die "Can’t fork: $!";
        if (! $pid) {
                my ($uuid, $ugid) = (getpwnam($user))[2, 3];
-               $)="$ugid $ugid";
+               my $grouplist=join(" ", $ugid, $ugid, supplemental_groups($user));
+               undef $!;
+               $)=$grouplist;
+               if ($!) {
+                       die "failed to set egid $grouplist: $!";
+               }
                $(=$ugid;
-               $>=$uuid;
                $<=$uuid;
-               if ($< != $uuid || $> != $uuid || $( != $ugid || $) ne "$ugid $ugid") {
+               $>=$uuid;
+               if ($< != $uuid || $> != $uuid || $( != $ugid) {
                        die "failed to drop permissions to $user";
                }
-               %ENV=();
-               $ENV{HOME}=(getpwnam($user))[7];
+               %ENV=(
+                       PATH => $ENV{PATH},
+                       HOME => (getpwnam($user))[7],
+               );
                exec("ikiwiki", "-setup", $setup, @ARGV);
                die "failed to run ikiwiki: $!";
        }